Surround audio support #2026
Merged
Surround audio support #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might as well add 2.1? some soundbars & simpler speaker kits use that. just FL+FR+SW |
I suppose, apparently we're meant to just mute the sub when downmixing so i suppose that's fine |
|
So i know there's also 4.1 (5ch) and 6.1 (7ch) but I can't find any particularly useful/trustworthy resources on how to downmix those correctly, so unless someone can give info on them I'll leave them out (they're not utilised very much, people tend to only use even numbers of channels) |
|
I'll review this tomorrow I have a headset with virtual surround sound to test with |
|
Anyway that was a lie |
Vixea
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for downmixing from 4, 6 and 8 channel audio to both stereo and mono.
Important note: This doesn't make Razer's THX Spatial Audio work (their audio device just returns all 0s for the audio samples).
Tested using VB Audio virtual devices.
This is unlikely to have any effect on audio quality (as most apps/games just use stereo anyway), but it will mean people with surround audio configurations won't end up with no audio on the headset side (unless they have a broken virtual surround setup like was mentioned above).