fix(connection): 🐛 use separate functions for local and broadcast soc…

…ket sends

alvr/client_core/src/connection.rs

@@ -138,14 +138,14 @@ fn connection_pipeline(
                 return Ok(());
             }
 
-            if let Err(e) = announcer_socket.announce_to(Ipv4Addr::BROADCAST) {
+            if let Err(e) = announcer_socket.announce_broadcast() {
                 warn!("Global broadcast error. Is network available? {e:?}");
 
                 set_hud_message(LOCAL_TRY_MESSAGE);
 
                 thread::sleep(RETRY_CONNECT_MIN_INTERVAL);
 
-                if let Err(e) = announcer_socket.announce_to(Ipv4Addr::LOCALHOST) {
+                if let Err(e) = announcer_socket.announce_local() {
                     warn!("Couldn't announce to neither network or localhost. {e:?}");
                     set_hud_message(NETWORK_UNREACHABLE_MESSAGE);
 

alvr/client_core/src/sockets.rs

@@ -20,8 +20,16 @@ impl AnnouncerSocket {
         Ok(Self { socket, packet })
     }
 
-    pub fn announce_to(&self, addr: Ipv4Addr) -> Result<()> {
-        self.socket.send_to(&self.packet, (addr, CONTROL_PORT))?;
+    pub fn announce_local(&self) -> Result<()> {
+        self.socket
+            .send_to(&self.packet, (Ipv4Addr::LOCALHOST, CONTROL_PORT))?;
+
+        Ok(())
+    }
+
+    pub fn announce_broadcast(&self) -> Result<()> {
+        self.socket
+            .send_to(&self.packet, (Ipv4Addr::BROADCAST, CONTROL_PORT))?;
 
         Ok(())
     }