ci(xtask): 📌 Fix cargo-msrv by rev pinning #837
zmerpAnnotations
138 warnings
|
wiki
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, cmbrose/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
wiki
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, cmbrose/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L408
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:408:25
|
408 | ui[1].label(&format!(
| _________________________^
409 | | "{}% ({})",
410 | | statistics.battery_hmd,
411 | | if statistics.hmd_plugged {
... |
415 | | }
416 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
408 ~ ui[1].label(format!(
409 + "{}% ({})",
410 + statistics.battery_hmd,
411 + if statistics.hmd_plugged {
412 + "plugged"
413 + } else {
414 + "unplugged"
415 + }
416 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L405
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:405:25
|
405 | ui[1].label(&format!("{} FPS", statistics.server_fps));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} FPS", statistics.server_fps)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L402
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:402:25
|
402 | ui[1].label(&format!("{} FPS", statistics.client_fps));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} FPS", statistics.client_fps)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L396
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:396:25
|
396 | ui[1].label(&format!(
| _________________________^
397 | | "{} packets ({} packets/s)",
398 | | statistics.packets_lost_total, statistics.packets_lost_per_sec
399 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
396 ~ ui[1].label(format!(
397 + "{} packets ({} packets/s)",
398 + statistics.packets_lost_total, statistics.packets_lost_per_sec
399 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L393
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:393:25
|
393 | ui[1].label(&format!("{:.2} ms", statistics.decode_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.decode_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L390
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:390:25
|
390 | ui[1].label(&format!("{:.2} ms", statistics.network_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.network_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L387
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:387:25
|
387 | ui[1].label(&format!("{:.2} ms", statistics.encode_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.encode_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L384
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:384:25
|
384 | ui[1].label(&format!("{:.0} ms", statistics.total_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.0} ms", statistics.total_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L381
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:381:25
|
381 | ui[1].label(&format!("{:.1} Mbps", statistics.video_mbits_per_sec));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.1} Mbps", statistics.video_mbits_per_sec)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L378
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:378:25
|
378 | ui[1].label(&format!("{} MB", statistics.video_mbytes_total));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} MB", statistics.video_mbytes_total)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L372
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:372:25
|
372 | ui[1].label(&format!(
| _________________________^
373 | | "{} packets ({} packets/s)",
374 | | statistics.video_packets_total, statistics.video_packets_per_sec
375 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
372 ~ ui[1].label(format!(
373 + "{} packets ({} packets/s)",
374 + statistics.video_packets_total, statistics.video_packets_per_sec
375 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L324
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:324:49
|
324 | ui.colored_label(color, &format!("{text}: {:.2} Mbps", value / 1e6));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{text}: {:.2} Mbps", value / 1e6)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L166
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:166:49
|
166 | ui.colored_label(color, &format!("{:.2}ms", value_s * 1000.0));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2}ms", value_s * 1000.0)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
function `notice` is never used:
alvr/dashboard/src/dashboard/components/settings_controls/notice.rs#L8
warning: function `notice` is never used
--> alvr/dashboard/src/dashboard/components/settings_controls/notice.rs:8:8
|
8 | pub fn notice(ui: &mut Ui, text: &str) {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
using `clone` on type `Instance` which implements the `Copy` trait:
alvr/client_openxr/src/extra_extensions/mod.rs#L48
warning: using `clone` on type `Instance` which implements the `Copy` trait
--> alvr/client_openxr/src/extra_extensions/mod.rs:48:33
|
48 | base_function_ptrs: instance.fp().clone(),
| ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*instance.fp()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
fields `aim_action` and `aim_space` are never read:
alvr/client_openxr/src/interaction.rs#L26
warning: fields `aim_action` and `aim_space` are never read
--> alvr/client_openxr/src/interaction.rs:26:9
|
22 | pub struct HandInteraction {
| --------------- fields in this struct
...
26 | pub aim_action: xr::Action<xr::Posef>,
| ^^^^^^^^^^
27 | pub aim_space: xr::Space,
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
alvr/client_openxr/src/lib.rs#L204
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:204:9
|
204 | let mut stream_config = None::<StreamConfig>;
| ----^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
alvr/client_openxr/src/lib.rs#L203
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:203:9
|
203 | let mut last_lobby_message = String::new();
| ----^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `xr_frame_stream`:
alvr/client_openxr/src/lib.rs#L216
warning: unused variable: `xr_frame_stream`
--> alvr/client_openxr/src/lib.rs:216:51
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`
|
|
unused variable: `xr_frame_waiter`:
alvr/client_openxr/src/lib.rs#L216
warning: unused variable: `xr_frame_waiter`
--> alvr/client_openxr/src/lib.rs:216:30
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`
|
|
unused variable: `xr_session`:
alvr/client_openxr/src/lib.rs#L216
warning: unused variable: `xr_session`
--> alvr/client_openxr/src/lib.rs:216:14
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`
|
|
unused variable: `stream_config`:
alvr/client_openxr/src/lib.rs#L204
warning: unused variable: `stream_config`
--> alvr/client_openxr/src/lib.rs:204:13
|
204 | let mut stream_config = None::<StreamConfig>;
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream_config`
|
|
unused variable: `last_lobby_message`:
alvr/client_openxr/src/lib.rs#L203
warning: unused variable: `last_lobby_message`
--> alvr/client_openxr/src/lib.rs:203:13
|
203 | let mut last_lobby_message = String::new();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable definition:
alvr/client_openxr/src/lib.rs#L222
warning: unreachable definition
--> alvr/client_openxr/src/lib.rs:222:13
|
218 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ------------------------------------------------ any code following this expression is unreachable
...
222 | let xr_context = XrContext {
| ^^^^^^^^^^ unreachable definition
|
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
--> alvr/client_openxr/src/lib.rs:218:45
|
218 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unreachable_code)]` on by default
|
|
doc list item without indentation:
alvr/client_core/src/c_api.rs#L489
warning: doc list item without indentation
--> alvr/client_core/src/c_api.rs:489:5
|
489 | /// eye_gazes:
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
489 | /// eye_gazes:
| ++
|
|
doc list item without indentation:
alvr/client_core/src/c_api.rs#L486
warning: doc list item without indentation
--> alvr/client_core/src/c_api.rs:486:5
|
486 | /// hand_skeleton:
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
486 | /// hand_skeleton:
| ++
|
|
fields `codec`, `force_software_decoder`, `max_buffering_frames`, `buffering_history_weight`, `options`, and `config_buffer` are never read:
alvr/client_core/src/decoder.rs#L7
warning: fields `codec`, `force_software_decoder`, `max_buffering_frames`, `buffering_history_weight`, `options`, and `config_buffer` are never read
--> alvr/client_core/src/decoder.rs:7:9
|
6 | pub struct DecoderConfig {
| ------------- fields in this struct
7 | pub codec: CodecType,
| ^^^^^
8 | pub force_software_decoder: bool,
| ^^^^^^^^^^^^^^^^^^^^^^
9 | pub max_buffering_frames: f32,
| ^^^^^^^^^^^^^^^^^^^^
10 | pub buffering_history_weight: f32,
| ^^^^^^^^^^^^^^^^^^^^^^^^
11 | pub options: Vec<(String, MediacodecDataType)>,
| ^^^^^^^
12 | pub config_buffer: Vec<u8>,
| ^^^^^^^^^^^^^
|
= note: `DecoderConfig` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
|
|
field `codec` is never read:
alvr/client_core/src/c_api.rs#L72
warning: field `codec` is never read
--> alvr/client_core/src/c_api.rs:72:9
|
71 | DecoderConfig {
| ------------- field in this variant
72 | codec: AlvrCodec,
| ^^^^^
|
|
fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read:
alvr/client_core/src/c_api.rs#L65
warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read
--> alvr/client_core/src/c_api.rs:65:9
|
64 | Haptics {
| ------- fields in this variant
65 | device_id: u64,
| ^^^^^^^^^
66 | duration_s: f32,
| ^^^^^^^^^^
67 | frequency: f32,
| ^^^^^^^^^
68 | amplitude: f32,
| ^^^^^^^^^
|
|
fields `view_width`, `view_height`, `refresh_rate_hint`, and `enable_foveated_encoding` are never read:
alvr/client_core/src/c_api.rs#L58
warning: fields `view_width`, `view_height`, `refresh_rate_hint`, and `enable_foveated_encoding` are never read
--> alvr/client_core/src/c_api.rs:58:9
|
57 | StreamingStarted {
| ---------------- fields in this variant
58 | view_width: u32,
| ^^^^^^^^^^
59 | view_height: u32,
| ^^^^^^^^^^^
60 | refresh_rate_hint: f32,
| ^^^^^^^^^^^^^^^^^
61 | enable_foveated_encoding: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
function `build_windows_installer` is never used:
alvr/xtask/src/packaging.rs#L13
warning: function `build_windows_installer` is never used
--> alvr/xtask/src/packaging.rs:13:4
|
13 | fn build_windows_installer() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `self::VkLoaderFeastureFlagBits as VkLoaderFlagBits`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L71964
warning: unused import: `self::VkLoaderFeastureFlagBits as VkLoaderFlagBits`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:71964:9
|
71964 | pub use self::VkLoaderFeastureFlagBits as VkLoaderFlagBits;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L64273
warning: unused import: `self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:64273:9
|
64273 | pub use self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L59508
warning: unused import: `self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:59508:9
|
59508 | pub use self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L56634
warning: unused import: `self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:56634:9
|
56634 | pub use self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L55649
warning: unused import: `self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:55649:9
|
55649 | pub use self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L53622
warning: unused import: `self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53622:9
|
53622 | pub use self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L53605
warning: unused import: `self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53605:9
|
53605 | pub use self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L53584
warning: unused import: `self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53584:9
|
53584 | pub use self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L53567
warning: unused import: `self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53567:9
|
53567 | pub use self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryTypeKHR as VkGeometryTypeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L53537
warning: unused import: `self::VkGeometryTypeKHR as VkGeometryTypeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53537:9
|
53537 | pub use self::VkGeometryTypeKHR as VkGeometryTypeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L53529
warning: unused import: `self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53529:9
|
53529 | pub use self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L52892
warning: unused import: `self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:52892:9
|
52892 | pub use self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerReductionMode as VkSamplerReductionModeEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L50733
warning: unused import: `self::VkSamplerReductionMode as VkSamplerReductionModeEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:50733:9
|
50733 | pub use self::VkSamplerReductionMode as VkSamplerReductionModeEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSubmitFlagBits as VkSubmitFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L44495
warning: unused import: `self::VkSubmitFlagBits as VkSubmitFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:44495:9
|
44495 | pub use self::VkSubmitFlagBits as VkSubmitFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L42667
warning: unused import: `self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42667:9
|
42667 | pub use self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreType as VkSemaphoreTypeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L42666
warning: unused import: `self::VkSemaphoreType as VkSemaphoreTypeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42666:9
|
42666 | pub use self::VkSemaphoreType as VkSemaphoreTypeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L42661
warning: unused import: `self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42661:9
|
42661 | pub use self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L42659
warning: unused import: `self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42659:9
|
42659 | pub use self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDriverId as VkDriverIdKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L42656
warning: unused import: `self::VkDriverId as VkDriverIdKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42656:9
|
42656 | pub use self::VkDriverId as VkDriverIdKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L42212
warning: unused import: `self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42212:9
|
42212 | pub use self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L42211
warning: unused import: `self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42211:9
|
42211 | pub use self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkChromaLocation as VkChromaLocationKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L42210
warning: unused import: `self::VkChromaLocation as VkChromaLocationKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42210:9
|
42210 | pub use self::VkChromaLocation as VkChromaLocationKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L41553
warning: unused import: `self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:41553:9
|
41553 | pub use self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPointClippingBehavior as VkPointClippingBehaviorKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L41552
warning: unused import: `self::VkPointClippingBehavior as VkPointClippingBehaviorKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:41552:9
|
41552 | pub use self::VkPointClippingBehavior as VkPointClippingBehaviorKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L40581
warning: unused import: `self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:40581:9
|
40581 | pub use self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L40563
warning: unused import: `self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:40563:9
|
40563 | pub use self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L40561
warning: unused import: `self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:40561:9
|
40561 | pub use self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L40369
warning: unused import: `self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:40369:9
|
40369 | pub use self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L39889
warning: unused import: `self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:39889:9
|
39889 | pub use self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L39871
warning: unused import: `self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:39871:9
|
39871 | pub use self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L39869
warning: unused import: `self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:39869:9
|
39869 | pub use self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L39607
warning: unused import: `self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:39607:9
|
39607 | pub use self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L39605
warning: unused import: `self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:39605:9
|
39605 | pub use self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L39520
warning: unused import: `self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:39520:9
|
39520 | pub use self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L39518
warning: unused import: `self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:39518:9
|
39518 | pub use self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkRenderingFlagBits as VkRenderingFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs#L39055
warning: unused import: `self::VkRenderingFlagBits as VkRenderingFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:39055:9
|
39055 | pub use self::VkRenderingFlagBits as VkRenderingFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L408
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:408:25
|
408 | ui[1].label(&format!(
| _________________________^
409 | | "{}% ({})",
410 | | statistics.battery_hmd,
411 | | if statistics.hmd_plugged {
... |
415 | | }
416 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
408 ~ ui[1].label(format!(
409 + "{}% ({})",
410 + statistics.battery_hmd,
411 + if statistics.hmd_plugged {
412 + "plugged"
413 + } else {
414 + "unplugged"
415 + }
416 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L405
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:405:25
|
405 | ui[1].label(&format!("{} FPS", statistics.server_fps));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} FPS", statistics.server_fps)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L402
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:402:25
|
402 | ui[1].label(&format!("{} FPS", statistics.client_fps));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} FPS", statistics.client_fps)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L396
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:396:25
|
396 | ui[1].label(&format!(
| _________________________^
397 | | "{} packets ({} packets/s)",
398 | | statistics.packets_lost_total, statistics.packets_lost_per_sec
399 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
396 ~ ui[1].label(format!(
397 + "{} packets ({} packets/s)",
398 + statistics.packets_lost_total, statistics.packets_lost_per_sec
399 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L393
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:393:25
|
393 | ui[1].label(&format!("{:.2} ms", statistics.decode_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.decode_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L390
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:390:25
|
390 | ui[1].label(&format!("{:.2} ms", statistics.network_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.network_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L387
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:387:25
|
387 | ui[1].label(&format!("{:.2} ms", statistics.encode_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.encode_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L384
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:384:25
|
384 | ui[1].label(&format!("{:.0} ms", statistics.total_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.0} ms", statistics.total_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L381
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:381:25
|
381 | ui[1].label(&format!("{:.1} Mbps", statistics.video_mbits_per_sec));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.1} Mbps", statistics.video_mbits_per_sec)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L378
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:378:25
|
378 | ui[1].label(&format!("{} MB", statistics.video_mbytes_total));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} MB", statistics.video_mbytes_total)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L372
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:372:25
|
372 | ui[1].label(&format!(
| _________________________^
373 | | "{} packets ({} packets/s)",
374 | | statistics.video_packets_total, statistics.video_packets_per_sec
375 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
372 ~ ui[1].label(format!(
373 + "{} packets ({} packets/s)",
374 + statistics.video_packets_total, statistics.video_packets_per_sec
375 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L324
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:324:49
|
324 | ui.colored_label(color, &format!("{text}: {:.2} Mbps", value / 1e6));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{text}: {:.2} Mbps", value / 1e6)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr/dashboard/src/dashboard/components/statistics.rs#L166
warning: the borrowed expression implements the required traits
--> alvr/dashboard/src/dashboard/components/statistics.rs:166:49
|
166 | ui.colored_label(color, &format!("{:.2}ms", value_s * 1000.0));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2}ms", value_s * 1000.0)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
function `notice` is never used:
alvr/dashboard/src/dashboard/components/settings_controls/notice.rs#L8
warning: function `notice` is never used
--> alvr/dashboard/src/dashboard/components/settings_controls/notice.rs:8:8
|
8 | pub fn notice(ui: &mut Ui, text: &str) {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
using `clone` on type `Instance` which implements the `Copy` trait:
alvr/client_openxr/src/extra_extensions/mod.rs#L48
warning: using `clone` on type `Instance` which implements the `Copy` trait
--> alvr/client_openxr/src/extra_extensions/mod.rs:48:33
|
48 | base_function_ptrs: instance.fp().clone(),
| ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*instance.fp()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
fields `aim_action` and `aim_space` are never read:
alvr/client_openxr/src/interaction.rs#L26
warning: fields `aim_action` and `aim_space` are never read
--> alvr/client_openxr/src/interaction.rs:26:9
|
22 | pub struct HandInteraction {
| --------------- fields in this struct
...
26 | pub aim_action: xr::Action<xr::Posef>,
| ^^^^^^^^^^
27 | pub aim_space: xr::Space,
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
alvr/client_openxr/src/lib.rs#L204
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:204:9
|
204 | let mut stream_config = None::<StreamConfig>;
| ----^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
alvr/client_openxr/src/lib.rs#L203
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:203:9
|
203 | let mut last_lobby_message = String::new();
| ----^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `xr_frame_stream`:
alvr/client_openxr/src/lib.rs#L216
warning: unused variable: `xr_frame_stream`
--> alvr/client_openxr/src/lib.rs:216:51
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`
|
|
unused variable: `xr_frame_waiter`:
alvr/client_openxr/src/lib.rs#L216
warning: unused variable: `xr_frame_waiter`
--> alvr/client_openxr/src/lib.rs:216:30
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`
|
|
unused variable: `xr_session`:
alvr/client_openxr/src/lib.rs#L216
warning: unused variable: `xr_session`
--> alvr/client_openxr/src/lib.rs:216:14
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`
|
|
unused variable: `stream_config`:
alvr/client_openxr/src/lib.rs#L204
warning: unused variable: `stream_config`
--> alvr/client_openxr/src/lib.rs:204:13
|
204 | let mut stream_config = None::<StreamConfig>;
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream_config`
|
|
unused variable: `last_lobby_message`:
alvr/client_openxr/src/lib.rs#L203
warning: unused variable: `last_lobby_message`
--> alvr/client_openxr/src/lib.rs:203:13
|
203 | let mut last_lobby_message = String::new();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable definition:
alvr/client_openxr/src/lib.rs#L222
warning: unreachable definition
--> alvr/client_openxr/src/lib.rs:222:13
|
218 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ------------------------------------------------ any code following this expression is unreachable
...
222 | let xr_context = XrContext {
| ^^^^^^^^^^ unreachable definition
|
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
--> alvr/client_openxr/src/lib.rs:218:45
|
218 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unreachable_code)]` on by default
|
|
unused variable: `config`:
alvr/server_core/src/connection.rs#L734
warning: unused variable: `config`
--> alvr/server_core/src/connection.rs:734:52
|
734 | let game_audio_thread = if let Switch::Enabled(config) = settings.audio.game_audio {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config`
|
|
unused variable: `game_audio_config`:
alvr/server_core/src/connection.rs#L593
warning: unused variable: `game_audio_config`
--> alvr/server_core/src/connection.rs:593:32
|
593 | if let Switch::Enabled(game_audio_config) = &settings.audio.game_audio {
| ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_game_audio_config`
|
= note: `#[warn(unused_variables)]` on by default
|
|
doc list item without indentation:
alvr/client_core/src/c_api.rs#L489
warning: doc list item without indentation
--> alvr/client_core/src/c_api.rs:489:5
|
489 | /// eye_gazes:
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
489 | /// eye_gazes:
| ++
|
|
doc list item without indentation:
alvr/client_core/src/c_api.rs#L486
warning: doc list item without indentation
--> alvr/client_core/src/c_api.rs:486:5
|
486 | /// hand_skeleton:
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
486 | /// hand_skeleton:
| ++
|
|
fields `codec`, `force_software_decoder`, `max_buffering_frames`, `buffering_history_weight`, `options`, and `config_buffer` are never read:
alvr/client_core/src/decoder.rs#L7
warning: fields `codec`, `force_software_decoder`, `max_buffering_frames`, `buffering_history_weight`, `options`, and `config_buffer` are never read
--> alvr/client_core/src/decoder.rs:7:9
|
6 | pub struct DecoderConfig {
| ------------- fields in this struct
7 | pub codec: CodecType,
| ^^^^^
8 | pub force_software_decoder: bool,
| ^^^^^^^^^^^^^^^^^^^^^^
9 | pub max_buffering_frames: f32,
| ^^^^^^^^^^^^^^^^^^^^
10 | pub buffering_history_weight: f32,
| ^^^^^^^^^^^^^^^^^^^^^^^^
11 | pub options: Vec<(String, MediacodecDataType)>,
| ^^^^^^^
12 | pub config_buffer: Vec<u8>,
| ^^^^^^^^^^^^^
|
= note: `DecoderConfig` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
|
|
field `codec` is never read:
alvr/client_core/src/c_api.rs#L72
warning: field `codec` is never read
--> alvr/client_core/src/c_api.rs:72:9
|
71 | DecoderConfig {
| ------------- field in this variant
72 | codec: AlvrCodec,
| ^^^^^
|
|
fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read:
alvr/client_core/src/c_api.rs#L65
warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read
--> alvr/client_core/src/c_api.rs:65:9
|
64 | Haptics {
| ------- fields in this variant
65 | device_id: u64,
| ^^^^^^^^^
66 | duration_s: f32,
| ^^^^^^^^^^
67 | frequency: f32,
| ^^^^^^^^^
68 | amplitude: f32,
| ^^^^^^^^^
|
|
fields `view_width`, `view_height`, `refresh_rate_hint`, and `enable_foveated_encoding` are never read:
alvr/client_core/src/c_api.rs#L58
warning: fields `view_width`, `view_height`, `refresh_rate_hint`, and `enable_foveated_encoding` are never read
--> alvr/client_core/src/c_api.rs:58:9
|
57 | StreamingStarted {
| ---------------- fields in this variant
58 | view_width: u32,
| ^^^^^^^^^^
59 | view_height: u32,
| ^^^^^^^^^^^
60 | refresh_rate_hint: f32,
| ^^^^^^^^^^^^^^^^^
61 | enable_foveated_encoding: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `alvr_audio::AudioDevice`:
alvr/server_core/src/connection.rs#L12
warning: unused import: `alvr_audio::AudioDevice`
--> alvr/server_core/src/connection.rs:12:5
|
12 | use alvr_audio::AudioDevice;
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
this returns a `Result<_, ()>`:
alvr/audio/src/linux.rs#L220
warning: this returns a `Result<_, ()>`
--> alvr/audio/src/linux.rs:220:1
|
220 | / pub fn record_audio_blocking_pipewire(
221 | | is_running: Arc<dyn Fn() -> bool + Send + Sync>,
222 | | sender: StreamSender<()>,
223 | | channels_count: u16,
224 | | sample_rate: u32,
225 | | ) -> Result<(), ()> {
| |___________________^
|
= help: use a custom `Error` type instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
= note: `#[warn(clippy::result_unit_err)]` on by default
|
|
function `build_windows_installer` is never used:
alvr/xtask/src/packaging.rs#L13
warning: function `build_windows_installer` is never used
--> alvr/xtask/src/packaging.rs:13:4
|
13 | fn build_windows_installer() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L408
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:408:25
|
408 | ui[1].label(&format!(
| _________________________^
409 | | "{}% ({})",
410 | | statistics.battery_hmd,
411 | | if statistics.hmd_plugged {
... |
415 | | }
416 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
408 ~ ui[1].label(format!(
409 + "{}% ({})",
410 + statistics.battery_hmd,
411 + if statistics.hmd_plugged {
412 + "plugged"
413 + } else {
414 + "unplugged"
415 + }
416 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L405
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:405:25
|
405 | ui[1].label(&format!("{} FPS", statistics.server_fps));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} FPS", statistics.server_fps)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L402
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:402:25
|
402 | ui[1].label(&format!("{} FPS", statistics.client_fps));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} FPS", statistics.client_fps)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L396
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:396:25
|
396 | ui[1].label(&format!(
| _________________________^
397 | | "{} packets ({} packets/s)",
398 | | statistics.packets_lost_total, statistics.packets_lost_per_sec
399 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
396 ~ ui[1].label(format!(
397 + "{} packets ({} packets/s)",
398 + statistics.packets_lost_total, statistics.packets_lost_per_sec
399 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L393
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:393:25
|
393 | ui[1].label(&format!("{:.2} ms", statistics.decode_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.decode_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L390
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:390:25
|
390 | ui[1].label(&format!("{:.2} ms", statistics.network_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.network_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L387
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:387:25
|
387 | ui[1].label(&format!("{:.2} ms", statistics.encode_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2} ms", statistics.encode_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L384
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:384:25
|
384 | ui[1].label(&format!("{:.0} ms", statistics.total_latency_ms));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.0} ms", statistics.total_latency_ms)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L381
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:381:25
|
381 | ui[1].label(&format!("{:.1} Mbps", statistics.video_mbits_per_sec));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.1} Mbps", statistics.video_mbits_per_sec)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L378
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:378:25
|
378 | ui[1].label(&format!("{} MB", statistics.video_mbytes_total));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} MB", statistics.video_mbytes_total)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L372
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:372:25
|
372 | ui[1].label(&format!(
| _________________________^
373 | | "{} packets ({} packets/s)",
374 | | statistics.video_packets_total, statistics.video_packets_per_sec
375 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
372 ~ ui[1].label(format!(
373 + "{} packets ({} packets/s)",
374 + statistics.video_packets_total, statistics.video_packets_per_sec
375 ~ ));
|
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L324
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:324:49
|
324 | ui.colored_label(color, &format!("{text}: {:.2} Mbps", value / 1e6));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{text}: {:.2} Mbps", value / 1e6)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\dashboard\src\dashboard\components\statistics.rs#L166
warning: the borrowed expression implements the required traits
--> alvr\dashboard\src\dashboard\components\statistics.rs:166:49
|
166 | ui.colored_label(color, &format!("{:.2}ms", value_s * 1000.0));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{:.2}ms", value_s * 1000.0)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
function `notice` is never used:
alvr\dashboard\src\dashboard\components\settings_controls\notice.rs#L8
warning: function `notice` is never used
--> alvr\dashboard\src\dashboard\components\settings_controls\notice.rs:8:8
|
8 | pub fn notice(ui: &mut Ui, text: &str) {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
using `clone` on type `Instance` which implements the `Copy` trait:
alvr\client_openxr\src\extra_extensions\mod.rs#L48
warning: using `clone` on type `Instance` which implements the `Copy` trait
--> alvr\client_openxr\src\extra_extensions\mod.rs:48:33
|
48 | base_function_ptrs: instance.fp().clone(),
| ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*instance.fp()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
fields `aim_action` and `aim_space` are never read:
alvr\client_openxr\src\interaction.rs#L26
warning: fields `aim_action` and `aim_space` are never read
--> alvr\client_openxr\src\interaction.rs:26:9
|
22 | pub struct HandInteraction {
| --------------- fields in this struct
...
26 | pub aim_action: xr::Action<xr::Posef>,
| ^^^^^^^^^^
27 | pub aim_space: xr::Space,
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
alvr\client_openxr\src\lib.rs#L204
warning: variable does not need to be mutable
--> alvr\client_openxr\src\lib.rs:204:9
|
204 | let mut stream_config = None::<StreamConfig>;
| ----^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
alvr\client_openxr\src\lib.rs#L203
warning: variable does not need to be mutable
--> alvr\client_openxr\src\lib.rs:203:9
|
203 | let mut last_lobby_message = String::new();
| ----^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `xr_frame_stream`:
alvr\client_openxr\src\lib.rs#L216
warning: unused variable: `xr_frame_stream`
--> alvr\client_openxr\src\lib.rs:216:51
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`
|
|
unused variable: `xr_frame_waiter`:
alvr\client_openxr\src\lib.rs#L216
warning: unused variable: `xr_frame_waiter`
--> alvr\client_openxr\src\lib.rs:216:30
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`
|
|
unused variable: `xr_session`:
alvr\client_openxr\src\lib.rs#L216
warning: unused variable: `xr_session`
--> alvr\client_openxr\src\lib.rs:216:14
|
216 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`
|
|
unused variable: `stream_config`:
alvr\client_openxr\src\lib.rs#L204
warning: unused variable: `stream_config`
--> alvr\client_openxr\src\lib.rs:204:13
|
204 | let mut stream_config = None::<StreamConfig>;
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream_config`
|
|
unused variable: `last_lobby_message`:
alvr\client_openxr\src\lib.rs#L203
warning: unused variable: `last_lobby_message`
--> alvr\client_openxr\src\lib.rs:203:13
|
203 | let mut last_lobby_message = String::new();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable definition:
alvr\client_openxr\src\lib.rs#L222
warning: unreachable definition
--> alvr\client_openxr\src\lib.rs:222:13
|
218 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ------------------------------------------------ any code following this expression is unreachable
...
222 | let xr_context = XrContext {
| ^^^^^^^^^^ unreachable definition
|
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
--> alvr\client_openxr\src\lib.rs:218:45
|
218 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unreachable_code)]` on by default
|
|
doc list item without indentation:
alvr\client_core\src\c_api.rs#L489
warning: doc list item without indentation
--> alvr\client_core\src\c_api.rs:489:5
|
489 | /// eye_gazes:
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
489 | /// eye_gazes:
| ++
|
|
doc list item without indentation:
alvr\client_core\src\c_api.rs#L486
warning: doc list item without indentation
--> alvr\client_core\src\c_api.rs:486:5
|
486 | /// hand_skeleton:
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
486 | /// hand_skeleton:
| ++
|
|
fields `adapter` and `dummy_surface` are never read:
alvr\client_core\src\graphics\mod.rs#L167
warning: fields `adapter` and `dummy_surface` are never read
--> alvr\client_core\src\graphics\mod.rs:167:5
|
165 | pub struct GraphicsContext {
| --------------- fields in this struct
166 | _instance: Instance,
167 | adapter: Adapter,
| ^^^^^^^
...
174 | dummy_surface: egl::Surface,
| ^^^^^^^^^^^^^
|
|
fields `codec`, `force_software_decoder`, `max_buffering_frames`, `buffering_history_weight`, `options`, and `config_buffer` are never read:
alvr\client_core\src\decoder.rs#L7
warning: fields `codec`, `force_software_decoder`, `max_buffering_frames`, `buffering_history_weight`, `options`, and `config_buffer` are never read
--> alvr\client_core\src\decoder.rs:7:9
|
6 | pub struct DecoderConfig {
| ------------- fields in this struct
7 | pub codec: CodecType,
| ^^^^^
8 | pub force_software_decoder: bool,
| ^^^^^^^^^^^^^^^^^^^^^^
9 | pub max_buffering_frames: f32,
| ^^^^^^^^^^^^^^^^^^^^
10 | pub buffering_history_weight: f32,
| ^^^^^^^^^^^^^^^^^^^^^^^^
11 | pub options: Vec<(String, MediacodecDataType)>,
| ^^^^^^^
12 | pub config_buffer: Vec<u8>,
| ^^^^^^^^^^^^^
|
= note: `DecoderConfig` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
|
|
field `codec` is never read:
alvr\client_core\src\c_api.rs#L72
warning: field `codec` is never read
--> alvr\client_core\src\c_api.rs:72:9
|
71 | DecoderConfig {
| ------------- field in this variant
72 | codec: AlvrCodec,
| ^^^^^
|
|
fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read:
alvr\client_core\src\c_api.rs#L65
warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read
--> alvr\client_core\src\c_api.rs:65:9
|
64 | Haptics {
| ------- fields in this variant
65 | device_id: u64,
| ^^^^^^^^^
66 | duration_s: f32,
| ^^^^^^^^^^
67 | frequency: f32,
| ^^^^^^^^^
68 | amplitude: f32,
| ^^^^^^^^^
|
|
fields `view_width`, `view_height`, `refresh_rate_hint`, and `enable_foveated_encoding` are never read:
alvr\client_core\src\c_api.rs#L58
warning: fields `view_width`, `view_height`, `refresh_rate_hint`, and `enable_foveated_encoding` are never read
--> alvr\client_core\src\c_api.rs:58:9
|
57 | StreamingStarted {
| ---------------- fields in this variant
58 | view_width: u32,
| ^^^^^^^^^^
59 | view_height: u32,
| ^^^^^^^^^^^
60 | refresh_rate_hint: f32,
| ^^^^^^^^^^^^^^^^^
61 | enable_foveated_encoding: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused imports: `InstanceDescriptor` and `InstanceFlags`:
alvr\client_core\src\graphics\mod.rs#L15
warning: unused imports: `InstanceDescriptor` and `InstanceFlags`
--> alvr\client_core\src\graphics\mod.rs:15:42
|
15 | Adapter, Device, Extent3d, Instance, InstanceDescriptor, InstanceFlags, Queue, Texture,
| ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^
|
|
unused import: `mem`:
alvr\client_core\src\graphics\mod.rs#L12
warning: unused import: `mem`
--> alvr\client_core\src\graphics\mod.rs:12:24
|
12 | use std::{ffi::c_void, mem, num::NonZeroU32, ptr};
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
function `build_windows_installer` is never used:
alvr\xtask\src\packaging.rs#L13
warning: function `build_windows_installer` is never used
--> alvr\xtask\src\packaging.rs:13:4
|
13 | fn build_windows_installer() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|