🎨 Clean and format Python code properly #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 25, 2021 08:46
alvarobartt
added
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎨 This PR basically addresses the problem with the Python code written for
investpy, as no standards were being used (or at least not in a super-serious way!). So on, the.pre-commit-config.yamlandsetup.cfgconfiguration files have been included so as to ensure that the package is compliant withflake8,black, andisort, following the best Python practices.🔥 Additionally, this PR also addresses some problems with extra files, files that were not used, etc.
🎉 All of this has been done so as to reduce the complexity of the package, since we're moving towards a simpler, cleaner, and better version of
investpyfor the upcomingv2.0release which will be huge!