Adding label-has-associated-control to jsx-a11y lint rules and associ…

…ated UI fixes (elastic#27039)
alvarezmelissa87 · Dec 12, 2018 · af9d3ba · af9d3ba
1 parent af681c2
commit af9d3ba
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -339,6 +339,7 @@ module.exports = {
         'jsx-a11y/click-events-have-key-events': 'off',
         'jsx-a11y/anchor-has-content': 'off',
         'jsx-a11y/tabindex-no-positive': 'off',
+        'jsx-a11y/label-has-associated-control': 'off',
         'jsx-a11y/aria-role': 'off',
       },
     },

diff --git a/packages/eslint-config-kibana/.eslintrc.js b/packages/eslint-config-kibana/.eslintrc.js
@@ -149,6 +149,7 @@ module.exports = {
     'jsx-a11y/role-supports-aria-props': 'error',
     'jsx-a11y/scope': 'error',
     'jsx-a11y/tabindex-no-positive': 'error',
+    'jsx-a11y/label-has-associated-control': 'error',  
     'react/jsx-equals-spacing': ['error', 'never'],
     'react/jsx-indent': ['error', 2],
     'react/no-will-update-set-state': 'error',

diff --git a/src/legacy/core_plugins/kibana/public/home/components/tutorial/number_parameter.js b/src/legacy/core_plugins/kibana/public/home/components/tutorial/number_parameter.js
@@ -29,6 +29,7 @@ export function NumberParameter({ id, label, value, setParameter }) {
     <div className="kuiSideBarFormRow">
       <label
         className="kuiSideBarFormRow__label"
+        htmlFor={id}
       >
         {label}
       </label>
@@ -38,6 +39,7 @@ export function NumberParameter({ id, label, value, setParameter }) {
           type="number"
           value={value}
           onChange={handleChange}
+          id={id}
         />
       </div>
     </div>

diff --git a/x-pack/plugins/canvas/public/expression_types/arg_types/series_style/simple_template.js b/x-pack/plugins/canvas/public/expression_types/arg_types/series_style/simple_template.js
@@ -33,7 +33,7 @@ export const SimpleTemplate = props => {
       {!color || color.length === 0 ? (
         <Fragment>
           <EuiFlexItem grow={false}>
-            <label>Color&nbsp;</label>
+            <span>Color&nbsp;</span>
           </EuiFlexItem>
           <EuiFlexItem grow={false}>
             <EuiLink onClick={() => handlePlain('color', '#000000')}>
@@ -44,11 +44,11 @@ export const SimpleTemplate = props => {
       ) : (
         <Fragment>
           <EuiFlexItem grow={false}>
-            <label>Color&nbsp;</label>
+            <label htmlFor="series-style">Color&nbsp;</label>
           </EuiFlexItem>
           <EuiFlexItem style={{ fontSize: 0 }}>
             <ColorPickerMini
-              id={'series-style'}
+              id="series-style"
               value={color}
               onChange={val => handlePlain('color', val)}
               colors={workpad.colors}