chore(deps): Flutter 3.27.1 and Dart 3.6.0 #534
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
==========================================
+ Coverage 23.75% 26.43% +2.68%
==========================================
Files 13 15 +2
Lines 160 174 +14
==========================================
+ Hits 38 46 +8
- Misses 122 128 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -7,7 +7,7 @@ ChipThemeData appChipThemeData({ | |||
| return ChipThemeData( | |||
| side: const BorderSide(color: Colors.black12), | |||
| shape: const StadiumBorder(), | |||
| backgroundColor: colorScheme.primary.withOpacity(0.2), | |||
There was a problem hiding this comment.
Deprecated withOpacity, because replaced to withValues(alpha) .
| @@ -16,5 +16,11 @@ class ColorConverter implements JsonConverter<Color, int> { | |||
| Color fromJson(int json) => Color(json); | |||
|
|
|||
| @override | |||
| int toJson(Color object) => object.value; | |||
| test('color converter ...', () async { | ||
| const converter = ColorConverter(); | ||
| const object = Color(0xFFFF0000); | ||
| final sut = converter.toJson(object); | ||
| expect(sut, 0xFFFF0000); | ||
| expect(Color(sut), isSameColorAs(const Color(0xFFFF0000))); | ||
| }); |
There was a problem hiding this comment.
Add test for ColorConverter!
riscait
force-pushed
the
flutter-3.27
branch
from
2ede555 to
5e7c63e
Compare
| min: 0.6, | ||
| max: 1.9, |
There was a problem hiding this comment.
The default value would be omitted, so we dared to use a value that is not close to the end of the list!
🙌 What's Done
✍️ What's Not Done
🖼️ Image Differences
🤼 Desired Review Method
Note
It is possible that a reviewer's will may cause a method to be implemented that is not selected.
📝 Additional Notes
Pre-launch Checklist