Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use initialization page and providers #532

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Dec 17, 2024

🙌 What's Done

  • Use initialization page/providers

Overview

(Japanese)

✍️ What's Not Done

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.43%. Comparing base (394afb4) to head (64f0117).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   26.43%   26.43%           
=======================================
  Files          15       15           
  Lines         174      174           
=======================================
  Hits           46       46           
  Misses        128      128           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394afb4...64f0117. Read the comment docs.

@riscait riscait force-pushed the use-initialization-provider branch 3 times, most recently from 76310c6 to be46376 Compare December 17, 2024 12:47
@github-actions github-actions bot removed the themes label Dec 17, 2024
@riscait riscait marked this pull request as ready for review December 17, 2024 22:20
@riscait riscait requested a review from a team as a code owner December 17, 2024 22:20
@riscait riscait requested review from k-nkmr and removed request for a team December 17, 2024 22:20
@k-nkmr
Copy link
Contributor

k-nkmr commented Dec 18, 2024

@riscait

I’m sorry, but the Figma link you provided keeps loading and doesn’t open for me. Would it be possible to share a screenshot or something similar instead? 🙇🏻‍♀️

@riscait
Copy link
Member Author

riscait commented Dec 18, 2024

@k-nkmr
I was able to open it in a browser incognito window, so it doesn't seem to be a problem with the URL or my account.
It's a lot of work to take screenshots of all the pages...
But the slides are what I shared at the study session the other day👌

Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@k-nkmr k-nkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait force-pushed the use-initialization-provider branch from be46376 to e41301a Compare December 27, 2024 10:40
@riscait riscait force-pushed the use-initialization-provider branch from e41301a to 64f0117 Compare December 27, 2024 10:56
@riscait riscait merged commit d21e28f into main Dec 27, 2024
8 checks passed
@riscait riscait deleted the use-initialization-provider branch December 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants