Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payment loop #30

Closed
wants to merge 12 commits into from
Closed

Fix payment loop #30

wants to merge 12 commits into from

Conversation

kingoflolz
Copy link
Contributor

No description provided.

jtremback and others added 10 commits January 24, 2018 22:59
This commit prevents `rita.sh` from doing everything as root by calling
sudo where the actual privilege is needed. Also, it makes the script
fetch network-lab by itself as needed

rita.sh:
* stop requiring root and start using sudo for the operations that
actually need it
* automatically download network-lab and change its path to
"./network-lab/"
* stop running "make install" for Babel

.gitignore:
* update test dependency location
Copy link
Contributor

@drozdziak1 drozdziak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this only once CI gets all green. I checked and problem is that the tests don't even build.

Unfortunately I'm not able to push code at the moment, but I'll try and identify the root causes of the build errors and describe them below

@jkilpatr
Copy link
Member

jkilpatr commented Feb 7, 2018

Superseded by #34

@jkilpatr jkilpatr closed this Feb 7, 2018
@jkilpatr jkilpatr deleted the fix-payment-loop branch February 7, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants