Clarity integration #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is primarily used as a last step before signing the resulting hash.
This commit additionally removes the compiled JSON NABI. The reason for that is that with clarity we're not yet at the point where we can just construct the full function signature using just function name. So for now we're hardcoding the signature.
jkilpatr
reviewed
Oct 4, 2018
This could be possible at least since d7c6e67 where incorrect change somehow slipped through PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite big, but worth it. A lot of commits where I'm changing branches but this is due to the fact that the dependencies are really tangled.