Simplified ABI encoder #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't make much sense at this moment as we don't do validation against the JSON ABI from a compiled contract. In future, though, we might want to reintroduce this feature and check if the size we're trying to encode (i.e. u64) is less or equal to the size of uint in the ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one assumes that the ABI is known in advance, and is not obtained by decoding JSON file.
This does very simplified encoding of basic types, and saves the hussle of encoding offsets of dynamic variables (which we are using) i.e. strings, bytes.
There are bunch of tests that correctly verifies the simplified encoder based on the examples https://solidity.readthedocs.io/en/develop/abi-spec.html#abi-json
Partly related to #21