Implement missing traits #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way an Address could be easily stored in a HashMap.
drozdziak1
approved these changes
Sep 26, 2018
This is WIP and probably not exactly what we want, but its just to move forward with compile errors.
This will allow to convert BigEndianInt into an "inner" type which is BigUint. This approach feels cleaner as we can use BigUint/BigInt directly when calculating stuff, but BigEndianInt just inside clarity to interact with the blockchain.
mpapierski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way an Address could be easily stored in a HashMap, and much more since the guac_rs relies heavily on Parity code and Parity code is rich in helpers, and traits that we didn't know yet.
Closes #23