Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output filepath option #12

Merged
merged 9 commits into from
Mar 21, 2022
Merged

Add output filepath option #12

merged 9 commits into from
Mar 21, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Mar 21, 2022

  • Added a parameter to let users output the minimum requirements to a filepath
  • Added unit and integration test for this

@gsheni gsheni self-assigned this Mar 21, 2022
@gsheni gsheni changed the title Add write to file option Add output filepath option Mar 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #12 (5a511d7) into main (d94b85a) will decrease coverage by 1.54%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   95.90%   94.36%   -1.55%     
==========================================
  Files           7        8       +1     
  Lines         244      266      +22     
==========================================
+ Hits          234      251      +17     
- Misses         10       15       +5     
Impacted Files Coverage Δ
minimum_dependency_generator/main.py 28.57% <0.00%> (-2.20%) ⬇️
...pendency_generator/minimum_dependency_generator.py 95.53% <60.00%> (-3.50%) ⬇️
minimum_dependency_generator/tests/test_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94b85a...5a511d7. Read the comment docs.

@gsheni gsheni marked this pull request as ready for review March 21, 2022 22:01
Gaurav Sheni added 2 commits March 21, 2022 18:01
Copy link

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gsheni ! Looks good to me.

@gsheni gsheni merged commit ec80ee8 into main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants