Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logic for the default value when the parent is missing #688

Closed
wants to merge 5 commits into from
Closed

Adding logic for the default value when the parent is missing #688

wants to merge 5 commits into from

Conversation

scorpioluck20
Copy link

@scorpioluck20 scorpioluck20 commented Jul 31, 2019

Pull Request Description

Adding logic for the default value in _calculate_direct_features. Now, if the parent missing, the calculated value will be the default value (not a 'nan').

Fixes #682

iaroslav0 added 2 commits July 31, 2019 22:45
…682)

Now, if the parent missing, the calculated value will be default value
@CLAassistant
Copy link

CLAassistant commented Jul 31, 2019

CLA assistant check
All committers have signed the CLA.

@scorpioluck20
Copy link
Author

As for this Pull Request. I run 'make test' and 'make lint'. It shows error as below.

flake8 featuretools && isort --check-only --recursive featuretools
ERROR: /work/featuretools/featuretools/init.py Imports are incorrectly sorted.

After using 'make lint-fix', the error is fixed, but the code cannot be run as some modules cannot be imported. I need to check out the code to be the original one.

…682)

Add test case, also update the exisiting test function
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #688 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   97.49%   97.49%   -0.01%     
==========================================
  Files         118      118              
  Lines        9713     9731      +18     
==========================================
+ Hits         9470     9487      +17     
- Misses        243      244       +1
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 99.37% <100%> (+0.01%) ⬆️
...s/computational_backends/feature_set_calculator.py 98.44% <100%> (+0.02%) ⬆️
...computational_backends/calculate_feature_matrix.py 97.89% <0%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c583ff1...af01408. Read the comment docs.

@rwedge rwedge mentioned this pull request Sep 17, 2019
@rwedge rwedge changed the base branch from master to main July 2, 2020 18:31
@rwedge
Copy link
Contributor

rwedge commented Oct 23, 2020

stale pr, closing for now. could move forward if it was updated to match current code

@rwedge rwedge closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When calculating direct features use default value if parent missing
3 participants