-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Featuretools logo with dark mode version #2632
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 404 404
Lines 24215 24215
=======================================
Hits 24088 24088
Misses 127 127 ☔ View full report in Codecov by Sentry. |
https://feature-labs-inc-featuretools--2632.com.readthedocs.build/en/2632/ |
@LakshmanKishore thank you for the MR. I looked at the docs build and it looks good in dark mode. Approved! |
@gsheni, thank you for the swift review and approval! I'm glad to hear that the documentation looks good in dark mode. I tried accessing the build docs link (link), but it seems to be showing a 403 forbidden error. Could you please check if there's any issue with the access permissions or if there's anything specific I need to do to view the documentation? Also, I wanted to express my gratitude for the opportunity to contribute to the repository. It was a fun experience, and I'm looking forward to more collaboration in the future. Thank you! |
Pull Request Description
This pull request fixes the issue with the Featuretools logo's visibility in dark mode. The issue was caused by the logo's black letters not being visible against the dark background. This pull request adds a white stroke to the letters and increases the stroke width to the SVG to ensure that the letters are visible in both light and dark modes.
Changes Made
Testing
Screenshots
Related Issues