Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Featuretools logo with dark mode version #2632

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

LakshmanKishore
Copy link
Contributor

@LakshmanKishore LakshmanKishore commented Nov 7, 2023

Pull Request Description

This pull request fixes the issue with the Featuretools logo's visibility in dark mode. The issue was caused by the logo's black letters not being visible against the dark background. This pull request adds a white stroke to the letters and increases the stroke width to the SVG to ensure that the letters are visible in both light and dark modes.

Changes Made

  • Added a white stroke to the letters in the Featuretools logo.
  • Increased the stroke width of the SVG.

Testing

  • Tested the logo's visibility in both light and dark modes.

Screenshots

  • Attached screenshots of the logo's visibility in both light and dark modes.

Related Issues

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbcf232) 99.47% compared to head (e2b8d88) 99.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2632   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files         404      404           
  Lines       24215    24215           
=======================================
  Hits        24088    24088           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LakshmanKishore
Copy link
Contributor Author

LakshmanKishore commented Nov 7, 2023

https://feature-labs-inc-featuretools--2632.com.readthedocs.build/en/2632/
I'm not able to see the build docs. It shows 403 forbidden.

@LakshmanKishore LakshmanKishore marked this pull request as ready for review November 10, 2023 12:24
@gsheni gsheni changed the title Update featuretools_nav2.svg Update Featuretools logo with dark mode version Dec 12, 2023
@gsheni
Copy link
Contributor

gsheni commented Dec 12, 2023

@LakshmanKishore thank you for the MR. I looked at the docs build and it looks good in dark mode. Approved!

@gsheni gsheni enabled auto-merge (squash) December 12, 2023 16:25
@LakshmanKishore
Copy link
Contributor Author

@gsheni, thank you for the swift review and approval! I'm glad to hear that the documentation looks good in dark mode.

I tried accessing the build docs link (link), but it seems to be showing a 403 forbidden error. Could you please check if there's any issue with the access permissions or if there's anything specific I need to do to view the documentation?

Also, I wanted to express my gratitude for the opportunity to contribute to the repository. It was a fun experience, and I'm looking forward to more collaboration in the future.

Thank you!

@thehomebrewnerd thehomebrewnerd merged commit 7209f8e into alteryx:main Feb 13, 2024
52 of 53 checks passed
@tamargrey tamargrey mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo visibility issue in the documentation
4 participants