Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wheel from setup_requires #1950

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Remove wheel from setup_requires #1950

merged 5 commits into from
Mar 11, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Need to remove wheel from setup_requires in setup.cfg as this will cause issues with building distribution with python -m build.

@thehomebrewnerd thehomebrewnerd requested a review from gsheni March 11, 2022 21:07
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1950 (ad6d61f) into main (3937593) will not change coverage.
The diff coverage is n/a.

❗ Current head ad6d61f differs from pull request most recent head c83cae9. Consider uploading reports for the commit c83cae9 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1950   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         146      146           
  Lines       16438    16438           
=======================================
  Hits        16273    16273           
  Misses        165      165           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3937593...c83cae9. Read the comment docs.

@thehomebrewnerd thehomebrewnerd enabled auto-merge (squash) March 11, 2022 22:30
@thehomebrewnerd thehomebrewnerd merged commit 71894e5 into main Mar 11, 2022
@gsheni gsheni deleted the update-setupcfg branch March 15, 2022 16:29
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants