Add support for Python 3.10 #1940
Conversation
.github/workflows/build_docs.yaml
Outdated
| @@ -13,7 +13,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python_version: ["3.7", "3.8", "3.9"] | |||
| python_version: ["3.7", "3.8", "3.9", "3.10"] | |||
There was a problem hiding this comment.
Not sure we can actually do this since 3.10 isn't supported by koalas and we use koalas in our docs. Woodwork only runs the docs build for 3.8 in its CI. Is it better to match Woodwork and only run on 3.8 or have all but 3.10 be run?
There was a problem hiding this comment.
Have all but 3.10 run (since its not slowing us down, and increase our testing scenarios).
There was a problem hiding this comment.
Do we need to put a note somewhere in the docs that 3.10 isn't support for Koalas (yet)?
There was a problem hiding this comment.
That also means the 3.10 unit tests koalas run is pretty much useless
Can we look into excluding them from the test runs?
Not exactly what we want but gives an idea:
https://github.community/t/how-to-conditionally-include-exclude-items-in-matrix-eg-based-on-branch/16853/6
There was a problem hiding this comment.
Seems like we would want to add
exclude:
- python_version: "3.10"
- libraries: "koalas"
if im understanding correctly
There was a problem hiding this comment.
oops
[Invalid workflow file: .github/workflows/unit_tests_with_latest_deps.yml#L18](https://github.com/alteryx/featuretools/actions/runs/1959930281/workflow)
The workflow is not valid. .github/workflows/unit_tests_with_latest_deps.yml (Line: 18, Col: 7): Unexpected value 'exclude'
There was a problem hiding this comment.
I think it would be
exclude:
- python_version: "3.10"
libraries: "koalas"
There was a problem hiding this comment.
using a dash mark for each would exclude all 3.10, and all koalas
There was a problem hiding this comment.
that is indeed what happened 🤦♀️ thank you!
Codecov Report
@@ Coverage Diff @@
## main #1940 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 146 146
Lines 16438 16438
=======================================
Hits 16273 16273
Misses 165 165 Continue to review full report at Codecov.
|
Closes #1803