Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error when DFS returns an empty list of features #1919

Merged
merged 15 commits into from
Mar 1, 2022
Merged

Better error when DFS returns an empty list of features #1919

merged 15 commits into from
Mar 1, 2022

Conversation

DavidQi
Copy link
Contributor

@DavidQi DavidQi commented Feb 18, 2022 •
edited by gsheni
Loading

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 18, 2022 •
edited
Loading

Codecov Report

Merging #1919 (128be18) into main (5974359) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1919   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         149      149           
  Lines       16424    16438   +14     
=======================================
+ Hits        16224    16238   +14     
  Misses        200      200
Impacted Files Coverage Δ
featuretools/synthesis/dfs.py 100.00% <100.00%> (ø)
featuretools/tests/synthesis/test_dfs_method.py 99.56% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5974359...128be18. Read the comment docs.

@gsheni gsheni changed the title update dfs error message when an empty list returned. issue #1309 Bbetter error when DFS returns an empty list of features Feb 18, 2022
@gsheni gsheni changed the title Bbetter error when DFS returns an empty list of features Better error when DFS returns an empty list of features Feb 18, 2022
@DavidQi DavidQi requested review from rwedge and a team and removed request for rwedge February 21, 2022 13:49
rwedge
rwedge reviewed Feb 28, 2022
View reviewed changes
featuretools/synthesis/dfs.py Outdated Show resolved Hide resolved
featuretools/synthesis/dfs.py Outdated Show resolved Hide resolved
rwedge
rwedge approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Congrats on your first contribution to Featuretools!

@mingdavidqi mingdavidqi merged commit af8d490 into main Mar 1, 2022
@mingdavidqi mingdavidqi deleted the update_dfs_error_message branch March 2, 2022 20:49
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingdavidqi mingdavidqi mingdavidqi left review comments

@rwedge rwedge rwedge approved these changes

Assignees

@DavidQi DavidQi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise better error when DFS returns an empty list of features
5 participants
@DavidQi @CLAassistant @rwedge @mingdavidqi @gsheni