Fill default values when parent is missing #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault_value_when_par_missing
Codecov Report
@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
+ Coverage 98.38% 98.51% +0.12%
==========================================
Files 135 135
Lines 14496 14485 -11
==========================================
+ Hits 14262 14270 +8
+ Misses 234 215 -19
Continue to review full report at Codecov.
|
thehomebrewnerd
changed the title
This was referenced Jan 27, 2021
rwedge
reviewed
Jan 28, 2021
featuretools/tests/conftest.py
Outdated
| @@ -152,6 +152,64 @@ def ks_diamond_es(pd_diamond_es): | |||
| return ft.EntitySet(id=pd_diamond_es.id, entities=entities, relationships=relationships) | |||
|
|
|||
|
|
|||
| @pytest.fixture(params=['pd_transactions_defaultvalue_es', 'dask_transactions_defaultvalue_es', 'ks_transactions_defaultvalue_es']) | |||
| def transactions_defaultvalue_es(request): | |||
There was a problem hiding this comment.
thoughts on shortening this to default_value_es and adjusting the other fixtures to match?
There was a problem hiding this comment.
Yeah, that would be cleaner for sure.
There was a problem hiding this comment.
@rwedge Updated
added 2 commits
January 28, 2021 15:40
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill default values when parent is missing
Replaces PR #1217
Closes #682