Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger tests on pull request events #1304

Merged
merged 19 commits into from
Jan 20, 2021
Merged

Trigger tests on pull request events #1304

merged 19 commits into from
Jan 20, 2021

Conversation

jeff-hernandez
Copy link
Contributor

@jeff-hernandez jeff-hernandez commented Jan 12, 2021 •
edited
Loading

The test workflow was updated to run when pull requests are opened and updated.

@jeff-hernandez jeff-hernandez marked this pull request as ready for review January 12, 2021 22:16
@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #1304 (c888de8) into main (6f7cead) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         135      135           
  Lines       14496    14496           
=======================================
  Hits        14262    14262           
  Misses        234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7cead...c888de8. Read the comment docs.

@jeff-hernandez jeff-hernandez changed the title Update Tests Workflow Trigger tests on pull request target events Jan 14, 2021
@jeff-hernandez jeff-hernandez changed the title Trigger tests on pull request target events Trigger tests on pull request events Jan 19, 2021
@jeff-hernandez jeff-hernandez requested a review from rwedge January 19, 2021 18:17
rwedge
rwedge approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (pending update with base branch)

@jeff-hernandez jeff-hernandez merged commit 359ee0d into main Jan 20, 2021
@jeff-hernandez jeff-hernandez deleted the update_tests branch January 20, 2021 16:40
@rwedge rwedge mentioned this pull request Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeff-hernandez @rwedge