Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Tests #1303

Merged
merged 8 commits into from
Jan 12, 2021
Merged

Reorganize Tests #1303

merged 8 commits into from
Jan 12, 2021

Conversation

thehomebrewnerd
Copy link
Contributor

Reorganize Tests

As the test suite has continued to grow, several tests seemed to be located in directories/files that did not align with the specific item being covered by the test. This PR attempt to resolve some of these issue and better place some tests in the directory or file that most closely aligns with the objective of the test.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1303 (1b614ac) into main (34a5dac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1303   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         134      135    +1     
  Lines       14473    14489   +16     
=======================================
+ Hits        14239    14255   +16     
  Misses        234      234           
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_dask_es.py 100.00% <ø> (ø)
featuretools/tests/entityset_tests/test_entity.py 100.00% <ø> (ø)
...aturetools/tests/entityset_tests/test_koalas_es.py 100.00% <ø> (ø)
...utational_backend/test_calculate_feature_matrix.py 99.44% <100.00%> (ø)
featuretools/tests/demo_tests/test_demo_data.py 100.00% <100.00%> (ø)
featuretools/tests/entityset_tests/test_es.py 98.71% <100.00%> (-0.14%) ⬇️
...etools/tests/entityset_tests/test_serialization.py 99.72% <100.00%> (+0.08%) ⬆️
...aturetools/tests/entityset_tests/test_timedelta.py 100.00% <100.00%> (ø)
...ools/tests/primitive_tests/test_primitive_utils.py 100.00% <100.00%> (ø)
featuretools/tests/synthesis/test_dask_dfs.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a5dac...1b614ac. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thehomebrewnerd thehomebrewnerd merged commit 3c00001 into main Jan 12, 2021
@thehomebrewnerd thehomebrewnerd deleted the reorg-tests branch January 12, 2021 22:37
@rwedge rwedge mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants