-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Data Checks errors #4274
Fixed Data Checks errors #4274
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4274 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 355 355
Lines 38956 38956
=====================================
Hits 38835 38835
Misses 121 121 |
b5dcdc1
to
1638869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just a note about the release note, but otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending Becca's comment!
@@ -1,3 +1,6 @@ | |||
# flake8: noqa 401 imported to force console mode for tqdm in jupyter notebooks | |||
from tqdm.auto import tqdm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added this import to get rid of this error Using 'tqdm.autonotebook.tqdm' in notebook mode. Use 'tqdm.tqdm' instead to force console mode (e.g. in jupyter console)
that appears in all the notebooks. Let me know if you think we should add it to a different file or anything
12911f8
to
90524ee
Compare
Resolves #4212