Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Data Checks errors #4274

Merged
merged 11 commits into from
Aug 18, 2023
Merged

Fixed Data Checks errors #4274

merged 11 commits into from
Aug 18, 2023

Conversation

remyogasawara
Copy link
Collaborator

Resolves #4212

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #4274 (90524ee) into main (60505c7) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4274   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        355     355           
  Lines      38956   38956           
=====================================
  Hits       38835   38835           
  Misses       121     121           

@remyogasawara remyogasawara force-pushed the 4212_data_checks_errors branch from b5dcdc1 to 1638869 Compare August 15, 2023 21:58
@remyogasawara remyogasawara changed the title Fix Data Checks Errors Fixed Data Checks errors Aug 15, 2023
@remyogasawara remyogasawara marked this pull request as ready for review August 15, 2023 23:12
Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just a note about the release note, but otherwise looks good

docs/source/release_notes.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Becca's comment!

@@ -1,3 +1,6 @@
# flake8: noqa 401 imported to force console mode for tqdm in jupyter notebooks
from tqdm.auto import tqdm
Copy link
Collaborator Author

@remyogasawara remyogasawara Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this import to get rid of this error Using 'tqdm.autonotebook.tqdm' in notebook mode. Use 'tqdm.tqdm' instead to force console mode (e.g. in jupyter console) that appears in all the notebooks. Let me know if you think we should add it to a different file or anything

@remyogasawara remyogasawara force-pushed the 4212_data_checks_errors branch from 12911f8 to 90524ee Compare August 18, 2023 15:54
@remyogasawara remyogasawara merged commit 2ad46d3 into main Aug 18, 2023
@remyogasawara remyogasawara deleted the 4212_data_checks_errors branch August 18, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadTheDocs - Data Checks errors
5 participants