Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade LightGBM and remove nullable handling #4237

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Upgrade LightGBM and remove nullable handling #4237

merged 4 commits into from
Jul 14, 2023

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Jul 14, 2023

Closes #4017

Shoutout to @tamargrey for making this so easy

@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Merging #4237 (98a024b) into main (841ac6d) will increase coverage by 15.3%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##            main   #4237      +/-   ##
========================================
+ Coverage   84.5%   99.7%   +15.3%     
========================================
  Files        349     349              
  Lines      38314   38281      -33     
========================================
+ Hits       32344   38162    +5818     
+ Misses      5970     119    -5851
Impacted Files Coverage Δ
...alml/tests/component_tests/test_lgbm_classifier.py 100.0% <ø> (ø)
...valml/tests/component_tests/test_lgbm_regressor.py 100.0% <ø> (ø)
...ents/estimators/classifiers/lightgbm_classifier.py 100.0% <100.0%> (ø)
...onents/estimators/regressors/lightgbm_regressor.py 100.0% <100.0%> (ø)

... and 36 files with indirect coverage changes

@eccabay eccabay marked this pull request as ready for review July 14, 2023 15:46
tamargrey
tamargrey approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad things work as expected!! LGTM

jeremyliweishih
jeremyliweishih approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf 🤌

@eccabay eccabay merged commit 9c4cfb5 into main Jul 14, 2023
@eccabay eccabay deleted the 4017_lgbm_nullable branch July 14, 2023 19:19
remyogasawara pushed a commit that referenced this pull request Jul 14, 2023
@eccabay @remyogasawara
Upgrade LightGBM and remove nullable handling (#4237)
34c80c6 
* Remove nullable type incompatibility tests

* Remove nullable type handling from lightgbm

* Bump min lightgbm version to 4.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@tamargrey tamargrey tamargrey approved these changes

@christopherbunn christopherbunn Awaiting requested review from christopherbunn

@MichaelFu512 MichaelFu512 Awaiting requested review from MichaelFu512

@remyogasawara remyogasawara Awaiting requested review from remyogasawara

Assignees

@eccabay eccabay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LightGBM: Remove nullable type handling when upgrading to LightGBM 4.0.0
3 participants
@eccabay @jeremyliweishih @tamargrey