-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise custom exception for pipeline errors #3497
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3497 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 336 336
Lines 33400 33420 +20
=======================================
+ Hits 33274 33294 +20
Misses 126 126
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fjlanasa !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit about docstrings, but looks good, thank you!
Pull Request Description
Adds new exception class
PipelineError
to be raised for errors encountered when applying pipelines. The first implementation will be for raising an error in_transform_features
when input data types are different from the input types the pipeline was fitted on.After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.