Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint against python 3.9 only #2586

Merged
merged 5 commits into from
Aug 5, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python_version: [ "3.7", "3.8", "3.9" ]
python_version: ["3.9" ]
steps:
- name: Set up Python ${{ matrix.python_version }}
uses: actions/setup-python@v2
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ clean:
.PHONY: lint
lint:
flake8 evalml && isort --check-only evalml && python docs/notebook_version_standardizer.py check-versions
black evalml --check
black evalml -t py39 --check

.PHONY: lint-fix
lint-fix:
black evalml
black -t py39 evalml
isort evalml
python docs/notebook_version_standardizer.py standardize

Expand Down
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Release Notes
* Changes
* Documentation Changes
* Testing Changes
* Changed the lint CI job to only check against python 3.9 via the `-t` flag :pr:`2586`

.. warning::

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def __init__(
allow_writing_files=False,
random_seed=0,
n_jobs=-1,
**kwargs
**kwargs,
):
parameters = {
"n_estimators": n_estimators,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __init__(
min_samples_split=2,
min_weight_fraction_leaf=0.0,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"criterion": criterion,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def __init__(
solver="saga",
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"penalty": penalty,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def __init__(
min_weight_fraction_leaf=0.0,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"n_estimators": n_estimators,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def __init__(
leaf_size=30,
p=2,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"n_neighbors": n_neighbors,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def __init__(
bagging_freq=0,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"boosting_type": boosting_type,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def __init__(
solver="lbfgs",
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"penalty": penalty,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def __init__(
gamma="scale",
probability=True,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"C": C,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def __init__(
n_estimators=100,
random_seed=0,
n_jobs=-1,
**kwargs
**kwargs,
):
parameters = {
"eta": eta,
Expand Down
2 changes: 1 addition & 1 deletion evalml/pipelines/components/estimators/estimator.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def __init__(self, parameters=None, component_obj=None, random_seed=0, **kwargs)
parameters=parameters,
component_obj=component_obj,
random_seed=random_seed,
**kwargs
**kwargs,
)

def _manage_woodwork(self, X, y=None):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def __init__(
allow_writing_files=False,
random_seed=0,
n_jobs=-1,
**kwargs
**kwargs,
):
parameters = {
"n_estimators": n_estimators,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __init__(
min_samples_split=2,
min_weight_fraction_leaf=0.0,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"criterion": criterion,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def __init__(
max_iter=1000,
normalize=False,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"alpha": alpha,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def __init__(
min_weight_fraction_leaf=0.0,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"n_estimators": n_estimators,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def __init__(
bagging_freq=0,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):

parameters = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def __init__(
seasonality_mode="additive",
random_seed=0,
stan_backend="CMDSTANPY",
**kwargs
**kwargs,
):
self.date_column = date_column

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def __init__(
n_estimators=100,
random_seed=0,
n_jobs=-1,
**kwargs
**kwargs,
):
parameters = {
"eta": eta,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def __init__(
handle_unknown="value",
handle_missing="value",
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"cols": cols,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def __init__(
threshold=-np.inf,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"number_features": number_features,
Expand All @@ -70,7 +70,7 @@ def __init__(
estimator=estimator,
max_features=max_features,
threshold=threshold,
**kwargs
**kwargs,
)
super().__init__(
parameters=parameters,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def __init__(
threshold=-np.inf,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):

parameters = {
Expand All @@ -71,7 +71,7 @@ def __init__(
estimator=estimator,
max_features=max_features,
threshold=threshold,
**kwargs
**kwargs,
)
super().__init__(
parameters=parameters,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def __init__(
impute_strategies=None,
default_impute_strategy="most_frequent",
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"impute_strategies": impute_strategies,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@ def __init__(
k_neighbors_default=5,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
super().__init__(
"SMOTE",
sampling_ratio=sampling_ratio,
k_neighbors_default=k_neighbors_default,
n_jobs=n_jobs,
random_seed=random_seed,
**kwargs
**kwargs,
)


Expand Down Expand Up @@ -63,7 +63,7 @@ def __init__(
k_neighbors_default=5,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
self.categorical_features = None
super().__init__(
Expand All @@ -72,7 +72,7 @@ def __init__(
k_neighbors_default=k_neighbors_default,
n_jobs=n_jobs,
random_seed=random_seed,
**kwargs
**kwargs,
)

def _get_categorical(self, X):
Expand Down Expand Up @@ -115,13 +115,13 @@ def __init__(
k_neighbors_default=5,
n_jobs=-1,
random_seed=0,
**kwargs
**kwargs,
):
super().__init__(
"SMOTEN",
sampling_ratio=sampling_ratio,
k_neighbors_default=k_neighbors_default,
n_jobs=n_jobs,
random_seed=random_seed,
**kwargs
**kwargs,
)
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def __init__(
min_samples=100,
min_percentage=0.1,
random_seed=0,
**kwargs
**kwargs,
):
parameters = {
"sampling_ratio": sampling_ratio,
Expand Down