Skip to content

Commit

Permalink
Automated Latest Dependency Updates (#4458)
Browse files Browse the repository at this point in the history
* Update latest dependencies

* Fix ruff command

* Remove Nate from deps review list

* Ignore lint rule E721

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: eccabay <[email protected]>
  • Loading branch information
3 people authored Aug 21, 2024
1 parent 92cf950 commit d5d42a4
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/latest_dependency_checker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
delete-branch: true
base: main
assignees: machineFL
reviewers: jeremyliweishih, thehomebrewnerd, MichaelFu512, eccabay, christopherbunn
reviewers: jeremyliweishih, MichaelFu512, eccabay, christopherbunn
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ repos:
additional_dependencies: [".[jupyter]"]
types_or: [python, jupyter]
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: 'v0.0.239'
rev: 'v0.5.1'
hooks:
- id: ruff
args:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ lint:
python docs/notebook_version_standardizer.py check-versions
python docs/notebook_version_standardizer.py check-execution
black . --check --config=./pyproject.toml
ruff . --config=./pyproject.toml
ruff check . --config=./pyproject.toml

.PHONY: lint-fix
lint-fix:
python docs/notebook_version_standardizer.py standardize
black . --config=./pyproject.toml
ruff . --config=./pyproject.toml --fix
ruff check . --config=./pyproject.toml --fix

.PHONY: test
test:
Expand Down
4 changes: 0 additions & 4 deletions evalml/pipelines/components/estimators/estimator.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import scipy.stats as st

from evalml.exceptions import MethodPropertyNotFoundError
from evalml.model_family import ModelFamily
from evalml.pipelines.components import ComponentBase
from evalml.problem_types import ProblemTypes
from evalml.utils import infer_feature_types
Expand Down Expand Up @@ -38,9 +37,6 @@ class Estimator(ComponentBase):
random_seed (int): Seed for the random number generator. Defaults to 0.
"""

model_family = ModelFamily.NONE
"""ModelFamily.NONE"""

modifies_features = True
modifies_target = False
training_only = False
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def _compute_delays(self, X_ww, y):
if isinstance(y, pd.DataFrame):
lagged_features.update(self._delay_df(y, y.columns))
else:
if type(y.ww.logical_type) == logical_types.Categorical:
if type(y.ww.logical_type) is logical_types.Categorical:
y = self._encode_y_while_preserving_index(y)
for t in self.statistically_significant_lags:
lagged_features[self.target_colname_prefix.format(t)] = y.shift(t)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1230,7 +1230,7 @@ def test_time_series_pipeline_parameter_warnings(
automl.search()

# We throw a warning about time series being in beta
assert w[0].category == UserWarning
assert w[0].category is UserWarning
if len(w) > 1:
assert w[1].message.components == set_values

Expand Down
4 changes: 2 additions & 2 deletions evalml/tests/component_tests/test_target_imputer.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,9 @@ def test_target_imputer_woodwork_custom_overrides_returned_by_components(
_, y_t = imputer.transform(None, y)

if impute_strategy_to_use == "most_frequent" or not has_nan:
assert type(y_t.ww.logical_type) == logical_type
assert type(y_t.ww.logical_type) is logical_type
else:
assert type(y_t.ww.logical_type) == Double
assert type(y_t.ww.logical_type) is Double


@pytest.mark.parametrize("impute_strategy", ["mean", "median", "most_frequent"])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ dask-expr==1.1.6
distributed==2024.6.2
featuretools==1.31.0
graphviz==0.20.3
holidays==0.51
holidays==0.52
imbalanced-learn==0.12.3
ipywidgets==8.1.3
kaleido==0.2.1
lightgbm==4.4.0
lime==0.2.0.1
matplotlib==3.9.0
matplotlib==3.9.1
matplotlib-inline==0.1.7
networkx==3.2.1
nlp-primitives==2.13.0
Expand Down
10 changes: 5 additions & 5 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ target-version = ["py39"]

[tool.ruff]
line-length = 88
select = [
lint.select = [
"D",
# Pyflakes
"F",
Expand All @@ -163,20 +163,20 @@ select = [
# isort
"I001"
]
ignore = ["E501", "D107", "D401"]
lint.ignore = ["E501", "D107", "D401", "E721"]
src = ["evalml"]

[tool.ruff.per-file-ignores]
[tool.ruff.lint.per-file-ignores]
"__init__.py" = ["E402", "F401", "I001", "E501"]
"evalml/tests/**" = ["D"]
"evalml/utils/**" = ["D"]
".github/**" = ["D"]
"docs/**" = ["D"]

[tool.ruff.isort]
[tool.ruff.lint.isort]
known-first-party = ["evalml"]

[tool.ruff.pydocstyle]
[tool.ruff.lint.pydocstyle]
convention = "google"

[tool.coverage.run]
Expand Down

0 comments on commit d5d42a4

Please sign in to comment.