-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Shuffled around the order of the DropColumns transformer in the tests…
… to accomodate the new check for Unknown in get_pp_components. Made Email get treated properly in testing as WW should infer it properly now. Made infer_feature_types replace all pd.NA with np.nan for series as well as dataframes.
- Loading branch information
1 parent
acc42bd
commit b4f1ae0
Showing
2 changed files
with
8 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,8 +64,8 @@ def _get_test_data_from_configuration( | |
"[email protected]", | ||
"[email protected]", | ||
"[email protected]", | ||
"$titanic_data%&@hotmail.com", | ||
"foo*EMAIL@email.org", | ||
"[email protected]", | ||
"fooEMAIL@email.org", | ||
"[email protected]", | ||
"[email protected]", | ||
], | ||
|
@@ -197,11 +197,7 @@ def test_make_pipeline( | |
if "text" in column_names and input_type == "ww" | ||
else [] | ||
) | ||
email_featurizer = ( | ||
[EmailFeaturizer] | ||
if "email" in column_names and input_type == "ww" | ||
else [] | ||
) | ||
email_featurizer = [EmailFeaturizer] if "email" in column_names else [] | ||
url_featurizer = ( | ||
[URLFeaturizer] if "url" in column_names and input_type == "ww" else [] | ||
) | ||
|
@@ -213,7 +209,7 @@ def test_make_pipeline( | |
) | ||
drop_col = ( | ||
[DropColumns] | ||
if any(ltype in column_names for ltype in ["url", "email", "text"]) | ||
if any(ltype in column_names for ltype in ["url", "text"]) | ||
and input_type == "pd" | ||
else [] | ||
) | ||
|
@@ -223,8 +219,8 @@ def test_make_pipeline( | |
+ url_featurizer | ||
+ drop_null | ||
+ text_featurizer | ||
+ imputer | ||
+ drop_col | ||
+ imputer | ||
+ datetime | ||
+ delayed_features | ||
+ ohe | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters