Fix compatibility issues with Featuretools #41
Conversation
|
|
autonormalize/autonormalize.py
Outdated
| if time_index in current.df.columns: | ||
| entities[current.index[0]] = (current.df, current.index[0], time_index) | ||
| entities[current_df_name] = (current.df, current.index[0], time_index) |
There was a problem hiding this comment.
As we have updated other libraries, we have moved away from using the entity/entities terminology in favor of dataframe/dataframes. If there are just a handful of places to update, maybe we should do that here now, but if there are a lot that need to be changed, we can create a new issue and work in it separately.
There was a problem hiding this comment.
Done! It wasn't too bad
autonormalize/autonormalize.py
Outdated
| @@ -143,7 +150,7 @@ def auto_normalize(df): | |||
|
|
|||
| def normalize_entity(es, accuracy=0.98): | |||
There was a problem hiding this comment.
Not sure if we want to update this from normalize_entity to normalize_dataframe as well?
There was a problem hiding this comment.
I actually think it should be normalize_entityset, but I didn't want to change the public API
docs/source/release_notes.rst
Outdated
| * Changes | ||
| * Rename `normalize_entity` to `normalize_entityset` (:pr:`41`) |
There was a problem hiding this comment.
Since this is a breaking change to the API, we typically have been including a Breaking Change note in the release notes. Here is an example: https://github.com/alteryx/woodwork/blob/main/docs/source/release_notes.rst#breaking-changes
Fix compatibility issues with Featuretools
fixes #39