Fix issues with auto_entityset #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage ? 94.74%
=========================================
Files ? 10
Lines ? 970
Branches ? 0
=========================================
Hits ? 919
Misses ? 51
Partials ? 0
Continue to review full report at Codecov.
|
|
|
rwedge
reviewed
May 10, 2022
autonormalize/dfd.py
Outdated
| masks.add_mask(attr, row[attr], m) | ||
| if mask is None: | ||
| mask = m | ||
| else: | ||
| mask = mask & m | ||
| options = df[mask] | ||
| _, unique_counts = numpy.unique(options[rhs].to_numpy(), return_counts=True) | ||
|
|
||
| # _, unique_counts = np.unique(options[rhs].to_numpy(), return_counts=True) |
There was a problem hiding this comment.
should this line be removed?
There was a problem hiding this comment.
Yep, removed this and another temporary test that I added trying to replicate the problem that was present in #19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues that were identified when trying to replicate the error described in Issue #19
The first change addresses a problem that resulted by trying to do an
==comparison betweennanvalues.The second change fixes an issue that can happen causing a column that is needed in other relationships to be dropped from an entity when
make_indexesis executed.Two additional tests were added to cover these scenarios.
Also, note, while these issues were discovered when testing for Issue #19, that specific error was not reproduced and it is unknown whether these changes will resolve that issue or not.