Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use magic wormhole for file transfer #41

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

altendky
Copy link
Owner

@altendky altendky commented Sep 6, 2019

No description provided.

src/romp/cli.py Outdated
wormhole_process = subprocess.Popen(
[
sys.executable,
'-c', entry_point_run_code,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe

Suggested change
'-c', entry_point_run_code,
os.path.join(sysconfig.get_path('scripts'), 'wormhole')

@altendky
Copy link
Owner Author

Kick CI.

@altendky altendky closed this Sep 13, 2019
@altendky altendky reopened this Sep 13, 2019
@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #41 into develop will decrease coverage by 1.1%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
- Coverage    78.21%   77.11%   -1.11%     
===========================================
  Files            8        8              
  Lines          381      402      +21     
  Branches        49       52       +3     
===========================================
+ Hits           298      310      +12     
- Misses          69       77       +8     
- Partials        14       15       +1
Impacted Files Coverage Δ
src/romp/_core.py 71.15% <50%> (-5.77%) ⬇️
src/romp/cli.py 85.93% <90%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602fe43...44e5cb7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant