Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix paste issue #2748

Merged
merged 1 commit into from
Jan 5, 2025
Merged

fix paste issue #2748

merged 1 commit into from
Jan 5, 2025

Conversation

imolorhe
Copy link
Collaborator

@imolorhe imolorhe commented Jan 5, 2025

upgrade codemirror packages

Fixes

Fixes #2747

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

Summary by Sourcery

Upgrade CodeMirror packages to fix a paste issue where newlines were not replaced with spaces.

Bug Fixes:

  • Fix an issue where pasting multi-line text into the input field would result in newlines instead of spaces.

Enhancements:

  • Upgrade CodeMirror from version 6.x.x to 6.36.1.

upgrade codemirror packages
Copy link

sourcery-ai bot commented Jan 5, 2025

Reviewer's Guide by Sourcery

This PR upgrades the CodeMirror package to fix a paste issue where newlines were not being replaced with spaces. It also updates the transaction changes to replace the entire document content instead of just inserting.

Sequence diagram for paste event handling in XInputComponent

sequenceDiagram
    actor User
    participant XInput as XInputComponent
    participant Editor as CodeMirror Editor
    participant State as Editor State

    User->>XInput: Paste text
    XInput->>Editor: Handle paste event
    Editor->>XInput: Trigger input.paste event
    Note over XInput: Check if event is paste
    XInput->>State: Create change transaction
    Note over XInput: Replace newlines with spaces
    State->>Editor: Apply changes
    Editor->>XInput: Update view
    XInput->>User: Show updated text
Loading

State diagram for paste handling in XInputComponent

stateDiagram-v2
    [*] --> Idle
    Idle --> ProcessingPaste: Paste Event
    ProcessingPaste --> ReplacingNewlines: Check Event Type
    ReplacingNewlines --> ApplyingChanges: Create Transaction
    ApplyingChanges --> Idle: Update View

    note right of ProcessingPaste: Detect input.paste
    note right of ReplacingNewlines: Replace \n with spaces
    note right of ApplyingChanges: Apply to entire document
Loading

File-Level Changes

Change Details Files
Upgrade CodeMirror packages
  • Updated CodeMirror dependencies to the latest versions.
  • Removed resolutions for CodeMirror packages.
pnpm-lock.yaml
packages/altair-app/package.json
Fix paste issue
  • Replace newlines with spaces on paste.
  • Replace entire document content on paste.
packages/altair-app/src/app/modules/altair/components/x-input/x-input.component.ts

Assessment against linked issues

Issue Objective Addressed Explanation
#2747 Fix the issue of trailing 'Bearer' being added when pasting a token in Set Headers
#2747 Ensure that pasting a token does not modify the original token with unwanted text

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imolorhe - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Jan 5, 2025

Visit the preview URL for this PR (updated for commit 591c0fc):

https://altair-gql--pr2748-imolorhe-fix-paste-i-i3kmynpd.web.app

(expires Sun, 12 Jan 2025 21:18:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 02d6323d75a99e532a38922862e269d63351a6cf

@imolorhe imolorhe added this pull request to the merge queue Jan 5, 2025
Merged via the queue into master with commit d04e78e Jan 5, 2025
15 checks passed
@imolorhe imolorhe deleted the imolorhe/fix-paste-issue branch January 5, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Pasting token in Set Headers adds trailing Bearer string
1 participant