Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow koa/router peer dependency > 11 #2632

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

imolorhe
Copy link
Collaborator

Fixes

Closes #2626

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

Copy link

Visit the preview URL for this PR (updated for commit 7a3fac1):

https://altair-gql--pr2632-imolorhe-update-koa-6hufwgb3.web.app

(expires Sat, 07 Sep 2024 03:53:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 02d6323d75a99e532a38922862e269d63351a6cf

@imolorhe imolorhe added this pull request to the merge queue Aug 31, 2024
Merged via the queue into master with commit 2f60b7f Aug 31, 2024
14 checks passed
@imolorhe imolorhe deleted the imolorhe/update-koa-router-peer branch August 31, 2024 04:44
@@ -23,7 +23,7 @@
"typescript": "5.2.2"
},
"peerDependencies": {
"@koa/router": "11 - 12"
"@koa/router": "> 11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to do >=11?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Fixed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the altair-koa-middleware peer dependency @koa/router
2 participants