Fix x show transition overlap #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimoTod
reviewed
Jun 2, 2020
There was a problem hiding this comment.
Thanks, I'd like to decrease the number of variable we set on el (I'm not sold on the timeout variable).
There is a point I don't understand, i'd like to know what we mean with If previous transitions still there, don't use resolve couple of other minor comments as well. Some of them could apply to the other PR as well (I haven't checked).
As a separate note, I strongly advise that we write a failing test first to prove that the PR fixes an existing bug (I'm sure it does but we don't have a regression test since everything passes in master).
|
Fixed by assigning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533 (tested) | #170 (tested, need more test) | #156 (partly tested, need more test) |
you tell meI have to refactor transition to achieve this solution. So there is a #542 Refactored Transition PR of this PR which has same solution + refactored transitions to let transitions has its own space so it will be easier to work on it. (it was really hard to work on existing transition code). I have explained much more on #542 since they serve almost same purpose.
This fix is quite self explanatory. I assigned few variables to check transitions and make sure and control how they are rendered.
By this, quick clicks overlapping transitions and wrong state of display issues will be fixed. There is also a test called
remaining transitions forced to complete if they existswhich tests this bug.Let me know if there is any room to improve. Huge thanks @SimoTod and @HugoDF for their comments. .5 x more thanks to @SimoTod for bearing with me :).