Skip to content
This repository has been archived by the owner on Feb 7, 2020. It is now read-only.

Add WordItem and WordList from wordlist repo with tests #72

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Add WordItem and WordList from wordlist repo with tests #72

merged 1 commit into from
Feb 4, 2019

Conversation

irina060981
Copy link
Member

@irina060981 irina060981 commented Feb 4, 2019 •
edited
Loading

Should be merged with the following pull request:
alpheios-project/wordlist#6

Also, I was to add this dependency:

"terser": "3.14.1",

because there is a new problem with building with webpack (here it is a github thread
vuejs/vue-cli#3407 )
Without it - it couldn't be build

@irina060981 irina060981 mentioned this pull request Feb 4, 2019
Merged
@irina060981 irina060981 requested a review from balmas February 4, 2019 13:59
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.06%) to 75.229% when pulling cfb3659 on move-word-list-to-data into f30dbab on master.

balmas
balmas approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@balmas balmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thank you!

@irina060981 irina060981 merged commit ec37571 into master Feb 4, 2019
@irina060981 irina060981 deleted the move-word-list-to-data branch February 4, 2019 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balmas balmas balmas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irina060981 @coveralls @balmas