Change: (ement-room--format-member-event) Quote reasons

For clarity (e.g. if a user displayname has a parenthetical, which would be rendered next to the reason, making it ambiguous).
alphapapa · Feb 6, 2024 · 38b5ec5 · 38b5ec5
1 parent 9450f74
commit 38b5ec5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/README.org b/README.org
@@ -298,6 +298,7 @@ Ement.el doesn't support encrypted rooms natively, but it can be used transparen
 *Changes*
 + Improve prompt used when viewing a room that is not joined.  ([[https://github.com/alphapapa/ement.el/issues/241][#241]].  Thanks to [[https://github.com/phil-s][Phil Sainty]].)
 + Format "was kicked and rejoined" membership event pairs.
++ Enclose reasons for membership events in quotes for clarity.
 
 ** 0.14
 

diff --git a/ement-room.el b/ement-room.el
@@ -3924,14 +3924,14 @@ a copy of the local keymap, and sets `header-line-format'."
                (format "%s left%s"
                        (prev-displayname-id-string)
                        (if reason
-                           (format " (%s)" reason)
+                           (format " (%S)" reason)
                          "")))
               (_ (format "%s kicked %s%s"
                          (sender-name-id-string)
                          (propertize (or prev-displayname state-key)
                                      'help-echo state-key)
                          (if reason
-                             (format " (%s)" reason)
+                             (format " (%S)" reason)
                            "")))))
            ("ban"
             (format "%s unbanned %s"
@@ -3940,7 +3940,7 @@ a copy of the local keymap, and sets `header-line-format'."
            (_ (format "%s left%s"
                       (prev-displayname-id-string)
                       (if reason
-                          (format " (%s)" reason)
+                          (format " (%S)" reason)
                         "")))))
         ("ban"
          (pcase prev-membership
@@ -3950,15 +3950,15 @@ a copy of the local keymap, and sets `header-line-format'."
                     (propertize (or prev-displayname state-key)
                                 'help-echo state-key)
                     (if reason
-                        (format " (%s)" reason)
+                        (format " (%S)" reason)
                       "")))
            ("join"
             (format "%s kicked and banned %s%s"
                     (sender-name-id-string)
                     (propertize (or prev-displayname state-key)
                                 'help-echo state-key)
                     (if reason
-                        (format " (%s)" reason)
+                        (format " (%S)" reason)
                       "")))
            (_ (format "%s sent unrecognized ban event for %s"
                       (sender-name-id-string)