Fix specialist_sector_cleanup task. #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alext
added a commit
to alphagov/govuk-lint
that referenced
this pull request
Jul 13, 2015
There are times when it's appropriate to use single quotes. Specifically when maintaining consistency within an area of the codebase (this linter it typically only applied to the diffs, and therefore won't take into account existing uses of single-quotes - eg alphagov/whitehall#2270). It therefore doesn't make sense to enforce this automatically.
This was blowing up if it encountered an orphaned tagging. This updates it to be more robust and handle this case.
alext
force-pushed
the
fix_specialist_sector_cleanup_task
branch
from
909afc8 to
3e40046
Compare
|
👍 |
alext
added a commit
that referenced
this pull request
Jul 14, 2015
…task Fix specialist_sector_cleanup task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was blowing up if it encountered an orphaned tagging. This updates
it to be more robust and handle this case.