Bump to Ruby 3.4.1 #3134
Draft
Bump to Ruby 3.4.1 #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another attempt to bump Ruby after hitting a problem with 3.3.5 [1]. [1]: #3063
This includes platforms for Docker on ARM (for GOV.UK Docker), ARM on linux (for production) and x86 64 on linux (for Github Actions)
This piece of code sets a default value for when you look up an item and the hash doesn't have a value. In Ruby 3.4 we have to specify a default hash value as an explicit hash, omitting the braces caused the arguments to be treated as keyword arguments and an error is raised: ``` ArgumentError: unknown keywords: :rank, :view_count ```
|
We still seem to be blocked from progressing with this due to the issue described in #3063 Where running the load_traffic task results in a GRPC error: As described in googleapis/google-cloud-ruby#27448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to bump Ruby after hitting a problem with 3.3.5 1.