Merge pull request #379 from alphagov/rm-errbit-handling-code

Remove handlers for apps sending exceptions to Errbit

Jenkinsfile

@@ -271,10 +271,10 @@ def makeLogsAvailable() {
   stage("Output Error log") {
     errors = sh(script: "test -s tmp/errors.log", returnStatus: true)
     if (errors == 0) {
-      echo("The following errors were logged with sentry/errbit:")
+      echo("The following errors were logged with Sentry")
       sh("cat tmp/errors.log")
     } else {
-      echo("No errors were sent to sentry/errbit")
+      echo("No errors were sent to Sentry")
     }
   }
 

diet-error-handler/README.md

@@ -1,11 +1,7 @@
 # Diet Error Handler
 
 This is a simple [Sinatra](http://www.sinatrarb.com/) app that is used as a
-replacement to [Sentry](https://sentry.io) and [Errbit](https://errbit.com/) in
-the end-to-end test environment.
-
-The usage of Errbit is deprecated and once no more of our apps use it we'll
-remove that integration.
+replacement to [Sentry](https://sentry.io) in the end-to-end test environment.
 
 It is used as means to create log files of errors that applications have
 reported. Otherwise you have to find the errors in the individual application

diet-error-handler/lib/notice.rb

@@ -1,20 +1,8 @@
 require "nokogiri"
 require "json"
-require_relative "notice/v2"
-require_relative "notice/v3"
 require_relative "notice/sentry"
 
 module Notice
-  def self.from_v2(notice_xml)
-    xml = Nokogiri::XML(notice_xml.force_encoding("UTF-8"))
-    Notice::V2.new(xml, Time.now)
-  end
-
-  def self.from_v3(notice_json)
-    json = JSON.parse(notice_json.force_encoding("UTF-8"))
-    Notice::V3.new(json, Time.now)
-  end
-
   def self.from_sentry(notice_json)
     json = JSON.parse(notice_json.force_encoding("UTF-8"))
     Notice::Sentry.new(json, Time.now)