Remove unused format_name property
#3112
Merged
+0
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBAshton
force-pushed
the
remove_format_name
branch
from
24b05f1 to
f479c26
Compare
ChrisBAshton
force-pushed
the
remove_format_name
branch
from
f479c26 to
42f0717
Compare
ChrisBAshton
added a commit
to alphagov/whitehall
that referenced
this pull request
Feb 3, 2025
Not to be confused with the widely used 'format_name' method names in Whitehall (e.g. 'detailed guidance' in alphagov/publishing-api#3112) These keys exactly duplicate the `title` property in the JSON file and are ultimately unused by finder-frontend and can be removed. See alphagov/publishing-api#3112 Trello: https://trello.com/c/ZiFU2o6B/3389-iterate-specialist-publisher-edit-new-finder-forms
ryanb-gds
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on:
format_nameproperty contacts-admin#1592format_namespecialist-publisher#2998format_nameproperty search-api#3139Trello: https://trello.com/c/ZiFU2o6B
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.