Content modelling/450 pact helpers for getting content with embeds #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will set up `details` in and a `link` in an expected state, as set out in the support of embedded content[1]. [1] #2813
This should support the GDS API Adapter tests being written here[1]. [1] alphagov/gds-api-adapters#1283
tahb
force-pushed
the
content-modelling/450-pact-helpers-for-getting-content-with-embeds
branch
from
d9be4b1 to
24510ae
Compare
| create( | ||
| :link, | ||
| edition: edition_with_embedded_edition, | ||
| link_type: :primary_publishing_organisation, |
There was a problem hiding this comment.
Do we need a link with link_type: :embed somewhere?
There was a problem hiding this comment.
Yes we do 👍 I added this to the new factory which is perhaps too mysterious and could be made explicit?
There was a problem hiding this comment.
Ohh, I see - that's fine, I just didn't follow it all the way through. No need to be any more explicit I don't think.
callumknights
approved these changes
Aug 29, 2024
tahb
deleted the
content-modelling/450-pact-helpers-for-getting-content-with-embeds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Pact helpers for getting content which embeds other content
This should support the GDS API Adapter tests being written here[1]. We can see a failure where that CI task is waiting for this code to be present[2].
[1] alphagov/gds-api-adapters#1283
[2] https://github.com/alphagov/gds-api-adapters/actions/runs/10595843267/job/29362556527?pr=1283