Remove placeholder logic #2504
Merged
Remove placeholder logic #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
remove-placeholder-logic
branch
7 times, most recently
from
9244ec5 to
a0c4286
Compare
brucebolt
added a commit
to alphagov/whitehall
that referenced
this pull request
Sep 14, 2023
We were previously sending some content items to Publishing API with a schema type prefixed `placeholder_` to indicate that content item was still rendered by Whitehall. This is no longer the case, so we can remove that logic. The `GenericEditionPresenter` is used solely in tests, reverting this to use a generic `placeholder` schema as the logic will be removed from Publishing API in alphagov/publishing-api#2504. This will need to be updated again when the `placeholder` schema is completely removed.
Placeholder schemas were added to hold documents that were rendered by Whitehall and not yet ready to be presented to end users. This added some complexity to Publishing API and Content Store, as these routes did not need to be registered with Router. Therefore removing this logic now all rendering has been migrated out of Whitehall.
The logic to deal with placeholder content has been removed, so we shouldn't be including them in examples.
Since all rendering has been moved out of Whitehall, there will be no documents published with the type of `placeholder`. Therefore removing it from the schemas.
brucebolt
force-pushed
the
remove-placeholder-logic
branch
from
a0c4286 to
d6512ee
Compare
jkempster34
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholder schemas were added to hold documents that were rendered by Whitehall and not yet ready to be presented to end users.
This added some complexity to Publishing API and Content Store, as these routes did not need to be registered with Router.
Therefore removing this logic now all rendering has been migrated out of Whitehall.
Depends on alphagov/whitehall#8251.
Trello card
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.