Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-12343: Add post merge package and release, and ensure package works on PRs #3

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

jfharden
Copy link
Contributor

@jfharden jfharden commented Mar 4, 2024

  1. Add a .pkl-version to the root of the repo which is loaded by all GitHub actions to decide the version of pkl to install
  2. In the unit tests use that version file, and also ensure the pkl project package can successfully run in the module
  3. Add a build directory which is gitignored
  4. Add a note to the README about how to release new versions
  5. Fix the baseUri in the PklProject
  6. Add post-merge workflow which will:
    1. Check if the version in the PklProject has a release already
    2. If there is not already a release run the pkl project package command; and
    3. Create a github release with the package artifacts

In order to test the post-merge workflow I set it to run on the PR, but to print debug output instead of creating the release, you can see a full run of it like that: https://github.com/alphagov/pkl-concourse-pipeline/actions/runs/8142949291/job/22253656509

I'll do another follow-on PR to update the README once I can write working tests using the published version.
I'll also squash the multiple commits in this PR when I merge it to save from the pointlessly noisy commit history

@jfharden jfharden marked this pull request as ready for review March 4, 2024 15:46
Copy link
Contributor

@kerrr kerrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jfharden jfharden merged commit 0a9c49f into main Mar 4, 2024
2 checks passed
@jfharden jfharden deleted the pp-12343/add-post-merge-package-and-release branch March 4, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants