Update weasyprint to render QR codes in letter #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it shows QR codes in PDF it creates. Version 51 did not do it.
CrystalPea
force-pushed
the
update-weasyprint
branch
from
c43c038 to
7a10f5d
Compare
samuelhwilliams
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
This looks good 👍
We checked to understand why the cache keys have changed and if it was concerning. It's not.
Some of the HTML is syntatically different - for example margin: 16pt 0 0 0; vs margin: 16.0pt 0 0 0;, but functionally and visually this is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weasyprint only started SVGs since version 53, and at first it was a bit buggy, so I updated to the latest version.
See this issue: Kozea/WeasyPrint#75