Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix for pyJWT #91

Merged
merged 2 commits into from
Dec 22, 2017
Merged

Security fix for pyJWT #91

merged 2 commits into from
Dec 22, 2017

Conversation

katstevens
Copy link
Contributor

What problem does the pull request solve?

The Digital Marketplace received a security alert on one of our repos that has the Notify Python client as a dependency. The version of pyJWT needs to be updated from >=1 to >=v1.5.1 to fix this vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2017-11424

Checklist

  • I’ve used the pull request template
  • I’ve written unit tests for these changes (no code changes, but I ran the existing tests locally, with Python 3.)
  • I’ve bumped the version number in
    • notifications_python_client/__init__.py
    • notifications_python_client/test_base_api_client.py, function test_user_agent_is_set

(I don't think any new documentation required - let me know if anything should be added.)

Thanks!

@allait allait requested a review from leohemsted December 20, 2017 15:54
Copy link
Contributor

@leohemsted leohemsted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants