Switch to %-style log formatting

We should let Python's logging module lazily interpolate the string.
This is generally recommended as the way to write log messages (over
eagerly formatting with either .format() or f-strings). This has two
benefits:

1) The 'processing' required to calculate the value of the variable
being interpolated doesn't need to happen unless the log message is
actually being emitted.
2) Sentry/etc can group together error log lines based on the base
unformatted message. If we eagerly interpolate, each log message will be
unique and so they don't get grouped together.

notifications_python_client/base.py

@@ -53,7 +53,7 @@ def generate_headers(self, api_token):
         }
 
     def request(self, method, url, data=None, params=None):
-        logger.debug("API request {} {}".format(method, url))
+        logger.debug("API request %s %s", method, url)
         url, kwargs = self._create_request_objects(url, data, params)
 
         response = self._perform_request(method, url, kwargs)
@@ -93,12 +93,12 @@ def _perform_request(self, method, url, kwargs):
         except requests.RequestException as e:
             api_error = HTTPError.create(e)
             logger.error(
-                "API {} request on {} failed with {} '{}'".format(method, url, api_error.status_code, api_error.message)
+                "API %s request on %s failed with %s '%s'", method, url, api_error.status_code, api_error.message
             )
             raise api_error
         finally:
             elapsed_time = time.monotonic() - start_time
-            logger.debug("API {} request on {} finished in {}".format(method, url, elapsed_time))
+            logger.debug("API %s request on %s finished in %s", method, url, elapsed_time)
 
     def _process_json_response(self, response):
         try:

notifications_python_client/notifications.py

@@ -72,7 +72,7 @@ def get_notification_by_id(self, id):
 
     def get_pdf_for_letter(self, id):
         url = "/v2/notifications/{}/pdf".format(id)
-        logger.debug("API request {} {}".format("GET", url))
+        logger.debug("API request %s %s", "GET", url)
         url, kwargs = self._create_request_objects(url, data=None, params=None)
 
         response = self._perform_request("GET", url, kwargs)

pyproject.toml

@@ -13,6 +13,7 @@ select = [
     "I",  # isort
     "B",  # flake8-bugbear
     "C90",  # mccabe cyclomatic complexity
+    "G",  # flake8-logging-format
 ]
 ignore = []
 exclude = [