Install uv using COPY and bump to latest version
#4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in: astral-sh/uv#11214 (comment) Without this we’re making an assumption about the venv existing (that we know because we just created it) that uv doesn’t know.
This is one of the recommended ways to install uv in their documentation: https://docs.astral.sh/uv/guides/integration/docker/#installing-uv
We can safely do this because: - the regression in 0.5.27 was fixed in https://github.com/astral-sh/uv/pull/11218/files - we added the location of the venv to an environment variable in this commit’s grandparent
leohemsted
approved these changes
Feb 6, 2025
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put venv location in environment variable
As suggested in astral-sh/uv#11214 (comment)
Without this we’re making an assumption about the venv existing (that we know because we just created it) that uv doesn’t know.
Install uv from Docker registry
This is one of the recommended ways to install uv in their documentation: https://docs.astral.sh/uv/guides/integration/docker/#installing-uv
It means we don’t need to specify the version number 3 times.
Bump uv to latest version
We can safely do this because:
PATHastral-sh/uv#11218