Download all local authority links #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGabbianelli
force-pushed
the
download-all-local-authority-links
branch
2 times, most recently
from
6aae0d2 to
7115d5f
Compare
AlanGabbianelli
changed the title
AlanGabbianelli
force-pushed
the
download-all-local-authority-links
branch
2 times, most recently
from
5aade6c to
96fef1e
Compare
AlanGabbianelli
force-pushed
the
download-all-local-authority-links
branch
2 times, most recently
from
8918fd2 to
82715cc
Compare
thomasleese
reviewed
Apr 16, 2019
AlanGabbianelli
force-pushed
the
download-all-local-authority-links
branch
from
82715cc to
c1d44be
Compare
added 4 commits
April 16, 2019 11:33
This versions silences Puma logs during spec suite: rspec/rspec-rails#1897
In development mode, having to restart the server every time we make a change is annoying and time consuming. This config will change the default behaviour. See: https://stackoverflow.com/questions/18270945/rails-server-needs-restart-every-time-i-make-changes-why
And rename currently_broken to broken
AlanGabbianelli
force-pushed
the
download-all-local-authority-links
branch
from
c1d44be to
c3617bc
Compare
The previous behaviour of clicking a link to download broken links has been modified so that the user can select specific statuses for which they want to download links. Only links with the selected status will be present in the downloaded csv file. They are initially all selected by default.
AlanGabbianelli
force-pushed
the
download-all-local-authority-links
branch
from
c3617bc to
f5dee13
Compare
thomasleese
approved these changes
Apr 16, 2019
AlanGabbianelli
pushed a commit
that referenced
this pull request
Apr 23, 2019
As users are now able to download a csv with all links for a specific local authority (see #413), we want to give them the ability to also upload that same csv with new links urls to be able to change in batch as many links urls as they want for that specific local authority. See specific commit messages for more context on other changes. Trello: https://trello.com/c/wpk9v5S9/877-allow-content-support-to-change-links-by-uploading-a-csv Co-Authored-By: Elliot Crosby-McCullough <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow download of links with specific statuses
The previous behaviour of clicking a link to download broken links has
been modified so that the user can select specific statuses for which
they want to download links. Only links with the selected status will be
present in the downloaded csv file. They are initially all selected by
default.
See specific commit messages for more context on other changes.
Trello: https://trello.com/c/Z6SmqxE3/938-add-button-to-download-all-links-for-a-council