Switch from using GOV.UK Jenkins to Travis #267

alexmuller · 2016-12-23T11:09:19Z

This project isn't owned by GOV.UK Publishing anymore so it needs to stop using Jenkins to publish changes.

Ideally I'd use a deploy key for this, but it turns out that you can't attach the same deploy key to more than one repo. This means that we're going to use a GitHub token attached to the govuk-ci user - this should be moved to a different user in the future. To make that happen:

Add the personal access token as a secure Travis env var
Change the Git URLs to push over HTTPS, not SSH

The gem_publisher gem expects there to be a file at .gem/credentials. I've encrypted that file for Travis and added that file to the Travis worker.

Same deal for the npm publish step.

alexmuller · 2016-12-23T11:10:19Z

I've deleted the webhook and disabled the Jenkins job.

alexmuller · 2016-12-23T11:55:53Z

Yay, it's working now I think. Had some trouble with encrypting multiple files for a while.

alexmuller · 2017-02-23T09:22:10Z

Add "DO NOT MERGE" so that this stops notifying my team's Slack until somebody is ready to review it.

dsingleton · 2017-02-24T12:49:13Z

.travis.yml

+  global:
+    - secure: "gxjwgl9l9ZP/1t86odZyMzWyiVBkG1oFzeL+Kb6z9Dtfu954l9RbytlenTTcnRw1KtaDBZVBs0ix3K45b8T2S6JFzLQ88Z/36DmXGIN6vxctfnVD9sqbbyOuP++RhibK+qUqbPRHo6a3wBsMQ87DMj5S6pJe3dxbCKRXa8zcMd0="
+before_install:
+  - openssl aes-256-cbc -K $encrypted_df4ab1bff570_key -iv $encrypted_df4ab1bff570_iv -in .travis/secrets.tar.enc -out .travis/secrets.tar -d


This will need to move the deploy steps from before_install to before_deploy, as ENV vars won't be available when running CI for forked PRs, which are common on this repo.

See alphagov/govuk_frontend_toolkit#385

Turns out before_deploy is run per deploy provider, and running this setup twice will cause an error, as we discovered on govuk_elements.

The most reliable way to limit decryption to situations where deployment is required is using if [ "$TRAVIS_PULL_REQUEST_BRANCH" = "master" ];, but this may not work well for multi-liners. See alphagov/govuk_elements#415.

dsingleton

Broadly looks good 👍

Checking / updating the npmrc auth details is a blocker, and moving before_install to before_deploy too, probably.

dsingleton · 2017-03-03T11:28:14Z

.travis.yml

+  - tar xvf .travis/secrets.tar
+  - mkdir -p ~/.gem/
+  - mv secrets/gem_credentials ~/.gem/credentials
+  - mv secrets/npmrc ~/.npmrc


I can't see the decrypted version of npmrc, but I suspect it might have the same npm v1 vs v2 issue as in alphagov/govuk_frontend_toolkit_npm#16 (comment).

This project isn't owned by GOV.UK Publishing anymore so it needs to stop using Jenkins to publish changes. Ideally I'd use a deploy key for this, but it turns out that you can't attach the same deploy key to more than one repo. This means that we're going to use a GitHub token attached to the govuk-ci user - this should be moved to a different user in the future. To make that happen: - Add the personal access token as a secure Heroku env var - Change the Git URLs to push over HTTPS, not SSH The gem_publisher gem expects there to be a file at `.gem/credentials`. I've encrypted that file for Travis and added that file to the Travis worker. Same deal for the `npm publish` command. It turns out you can only encrypt one file at a time which means that we need to create a tar archive and then move things around afterwards which is a little bit horrible. In order to do this I made a secrets directory and added 2 files: gem_credentials: ``` --- :rubygems_api_key: redacted ``` npmrc: ``` _auth = redacted email = [email protected] ``` And then ran: ``` tar cvf secrets.tar secrets/npmrc secrets/gem_credentials ``` And encrypted that file following these docs: https://docs.travis-ci.com/user/encrypting-files/

This copies the before_install step into a new script deploy provider.

This is the default for Ruby projects. Travis will run bundle install --jobs=3 --retry=3 by default when a Gemfile is found in the project’s root directory.

Caching the bundle between builds drastically reduces the time a build takes to run.

dsingleton

I've added comments but those are docs improvements that we should make once this is working.

Happy to merge so we test it.

dsingleton · 2017-03-23T14:42:48Z

.travis.yml

+env:
+  global:
+    - secure: "gxjwgl9l9ZP/1t86odZyMzWyiVBkG1oFzeL+Kb6z9Dtfu954l9RbytlenTTcnRw1KtaDBZVBs0ix3K45b8T2S6JFzLQ88Z/36DmXGIN6vxctfnVD9sqbbyOuP++RhibK+qUqbPRHo6a3wBsMQ87DMj5S6pJe3dxbCKRXa8zcMd0="
+before_install:


I think both of these commands were specific to how Jenkins worked, and we shouldn't need them for Travis.

dsingleton · 2017-03-23T14:44:14Z

.travis.yml

-  - echo "Not running Travis installation"
+env:
+  global:
+    - secure: "gxjwgl9l9ZP/1t86odZyMzWyiVBkG1oFzeL+Kb6z9Dtfu954l9RbytlenTTcnRw1KtaDBZVBs0ix3K45b8T2S6JFzLQ88Z/36DmXGIN6vxctfnVD9sqbbyOuP++RhibK+qUqbPRHo6a3wBsMQ87DMj5S6pJe3dxbCKRXa8zcMd0="


Could we add a comment to show what gets set here? I'm assuming it's the GH_TOKEN env variable, but it's not obvious from the Travis file alone.

dsingleton · 2017-03-23T15:43:36Z

This means that we're going to use a GitHub token attached to the govuk-ci user - this should be moved to a different user in the future

Should move from govuk-ci to a different user? That seems like a good fit for now.

Otherwise, i think we're happy with the changes and the next step is to merge and test the various deployment setup/providers - as we have with other repos.

Add information about the contents of this folder and how to update it.

Update the `npmrc` file to use the NPM v2+ auth format. See: https://docs.travis-ci.com/user/deployment/npm/ The NPM 2+ format looks like: ``` //registry.npmjs.org/:_authToken=XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX ``` The rubygems auth/API key should not have changed.

alexmuller force-pushed the switch-jenkins-to-travis branch 5 times, most recently from 9bea3c5 to 9db368c Compare December 23, 2016 11:54

alexmuller force-pushed the switch-jenkins-to-travis branch from 9db368c to 7a0c95a Compare January 5, 2017 10:41

alexmuller changed the title ~~Switch from using GOV.UK Jenkins to Travis~~ [DO NOT MERGE] Switch from using GOV.UK Jenkins to Travis Feb 23, 2017

dsingleton reviewed Feb 24, 2017

View reviewed changes

dsingleton suggested changes Mar 3, 2017

View reviewed changes

robinwhittleton mentioned this pull request Mar 16, 2017

Version 0.20.0 #282

Merged

dsingleton mentioned this pull request Mar 17, 2017

Fixes for Travis when deploying alphagov/govuk_frontend_toolkit#393

Merged

alexmuller and others added 5 commits March 23, 2017 11:00

Move the Travis config into a new config script

3cb93d5

This copies the before_install step into a new script deploy provider.

Add a before_deploy check to ensure the build was successful

cb9e48b

Remove the install step

ceae821

This is the default for Ruby projects. Travis will run bundle install --jobs=3 --retry=3 by default when a Gemfile is found in the project’s root directory.

Enable bundler caching to speed up the build

19b715d

Caching the bundle between builds drastically reduces the time a build takes to run.

gemmaleigh force-pushed the switch-jenkins-to-travis branch from 7a0c95a to 19b715d Compare March 23, 2017 11:36

dsingleton approved these changes Mar 23, 2017

View reviewed changes

dsingleton changed the title ~~[DO NOT MERGE] Switch from using GOV.UK Jenkins to Travis~~ Switch from using GOV.UK Jenkins to Travis Mar 23, 2017

gemmaleigh and others added 2 commits March 23, 2017 16:01

Add a section on encrypting files for Travis to the README

2c55257

Add information about the contents of this folder and how to update it.

gemmaleigh force-pushed the switch-jenkins-to-travis branch from 264ec10 to b43c1e2 Compare March 23, 2017 16:05

gemmaleigh merged commit b51b92e into master Mar 23, 2017

36degrees deleted the switch-jenkins-to-travis branch April 24, 2020 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch from using GOV.UK Jenkins to Travis #267

Switch from using GOV.UK Jenkins to Travis #267

alexmuller commented Dec 23, 2016 •

edited by dsingleton

Loading

alexmuller commented Dec 23, 2016

alexmuller commented Dec 23, 2016

alexmuller commented Feb 23, 2017

dsingleton Feb 24, 2017

dsingleton Mar 9, 2017

dsingleton left a comment

dsingleton Mar 3, 2017

dsingleton left a comment

dsingleton Mar 23, 2017

dsingleton Mar 23, 2017

dsingleton commented Mar 23, 2017

Switch from using GOV.UK Jenkins to Travis #267

Switch from using GOV.UK Jenkins to Travis #267

Conversation

alexmuller commented Dec 23, 2016 • edited by dsingleton Loading

alexmuller commented Dec 23, 2016

alexmuller commented Dec 23, 2016

alexmuller commented Feb 23, 2017

dsingleton Feb 24, 2017

Choose a reason for hiding this comment

dsingleton Mar 9, 2017

Choose a reason for hiding this comment

dsingleton left a comment

Choose a reason for hiding this comment

dsingleton Mar 3, 2017

Choose a reason for hiding this comment

dsingleton left a comment

Choose a reason for hiding this comment

dsingleton Mar 23, 2017

Choose a reason for hiding this comment

dsingleton Mar 23, 2017

Choose a reason for hiding this comment

dsingleton commented Mar 23, 2017

alexmuller commented Dec 23, 2016 •

edited by dsingleton

Loading