Add GA4 to nested contents item links #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
approved these changes
Sep 26, 2023
- include GA4 attributes for tracking on nested contents item links - includes new code to calculate the index_total (total number of links) and the index_link value for each link - note that where a contents list item is 'active' (i.e. not a link) this should not alter the overall index_total or index_link values, it is assumed that this non-link item is included in those counts
andysellick
force-pushed
the
ga4-contents-list-nested
branch
from
56fcc41 to
8f3fc15
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Index values should be as follows:
Why
We weren't tracking clicks on nested contents items links, only on top level items.
Visual Changes
One tiny change to the doc page for this component, under GA4 tracking include an
activeitem to help with testing.Trello card: https://trello.com/c/ZD50PFtM/693-add-tracking-to-dashed-child-content-items