Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs with the GA4 pageview tracker #3626

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Fix various bugs with the GA4 pageview tracker #3626

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29371eb
Strip _ga/_gl before redacting PII
AshGDS Sep 21, 2023
acb328d
Fix the HTML language never being used to set GA4 language
AshGDS Sep 21, 2023
0d6cc42
Reintroduce highest level of PII on GA4 location and title
AshGDS Sep 21, 2023
48ab079
Update CHANGELOG.md
AshGDS Sep 21, 2023
f66f9ce
PR Change: use variable
AshGDS Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/assets/javascripts/govuk_publishing_components/analytics-ga4/ga4-page-views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ window.GOVUK.analyticsGa4.analyticsModules = window.GOVUK.analyticsGa4.analytics
var content = document.getElementById('content')
var html = document.querySelector('html')
if (content) {
return content.getAttribute('lang') || this.nullValue
if (content.getAttribute('lang')) {
return content.getAttribute('lang')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're calling this twice, you should probably store it in a variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, good spot 👍

}
}
// html.getAttribute('lang') is untested - Jasmine would not allow lang to be set on <html>.
return html.getAttribute('lang') || this.nullValue
Expand Down