Add new light action link variant

[patrickpatrickpatrick]

What

Add new variant of action link for the homepage. Add new svg app/assets/images/govuk_publishing_components/action-link-arrow--light.svg. Add new png app/assets/images/govuk_publishing_components/action-link-arrow--light.png.

Why

As part of the changes being made to the homepage.

Screenshot

[maxgds]

No criticism on you, Patrick, but I don't understand why another variant is needed? We have multiple options already (and I'm unsure how many are actually used). The classname is treating "homepage" as a state but being on a homepage isn't really a state as such. What is the differentiating factor that leads to this variation being needed? It seems purely decorative - are we at a point where we should just be refactoring the component and passing arrow colours and background colours in instead of making a new one for each use case - which is somewhat against the principles of components being reusable.

[patrickpatrickpatrick]

No criticism on you, Patrick, but I don't understand why another variant is needed? We have multiple options already (and I'm unsure how many are actually used). The classname is treating "homepage" as a state but being on a homepage isn't really a state as such. What is the differentiating factor that leads to this variation being needed? It seems purely decorative - are we at a point where we should just be refactoring the component and passing arrow colours and background colours in instead of making a new one for each use case - which is somewhat against the principles of components being reusable.

The 'homepage' naming isn't the best, you are right. A better name that more in-line with the convention would be 'dark arrow light background'. Alternatively this does not need to be a change to the action link component, this component just reside in the frontend application as there isn't an immediate application for this change on other pages.

The work here is following a precedent that has been established but it isn't necessarily a good precedent. That is a good point. The action link component is an icon (which isn't necessarily an arrow, there are examples where this isn't the case) and a link. I suppose if we were to refactor it correctly, then perhaps it should take a path to an icon as argument and the icon should reside in the application that is rendering the action_link?

[maxgds]

I think in the interests of serving the instant need this is ok to go in, but please raise an issue to the effect of the previous conversation - this component is in severe need of rationalising, probably something to do in conjunction with design.